-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use iam-policy value for EMAIL if case-sensitive. #1937
Use iam-policy value for EMAIL if case-sensitive. #1937
Conversation
Hi @IMBurbank. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
This PR passed presubmit checks a few days ago, but is beginning to go stale sitting unmerged. The first branch conflict just arose today. Is there anything else I can do to help this PR through? |
Sorry about the delay. /lgtm |
@IMBurbank Can you please update by merging master. |
No problem, and thank you for the response. Another PR moved the |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhi-g The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1936
Modify
kfctl.createEnv
to check for a case-mismatch between theEMAIL
value provided by$(gcloud config get-value account)
and the value in the iam-policy, and to use the iam-policy value in the case of a mismatch.This change is