-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bindRoleHandler which bind roles to service accounts #1335
Conversation
What is the reasoning behind deciding which RPCs to expose? Why not simply expose a high level function that performs all the needed steps? If you look at kfctl.sh There are two commands Why not just have two similar RPCs? And treat specific RPCs (like role bindings as internal RPCs). |
@jlewi |
/retest |
2 similar comments
/retest |
/retest |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* add bindRoleHandler which bind roles to service accounts * handle review feedback: give more high level handler
* Upload 0.0.4 SDK version * Fix doc links * Fix links in README * Modify tables * Fix link * Remove * Modify client and gen script * Update version to 0.0.5 * Run CI * Add Katib client to init
adding expected test changes
Provide this handler so we can edit service account roles used by kubeflow through backend server.
This change is