Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bindRoleHandler which bind roles to service accounts #1335

Merged
merged 2 commits into from
Aug 10, 2018

Conversation

kunmingg
Copy link
Contributor

@kunmingg kunmingg commented Aug 9, 2018

Provide this handler so we can edit service account roles used by kubeflow through backend server.


This change is Reviewable

@kunmingg
Copy link
Contributor Author

kunmingg commented Aug 9, 2018

/assign @jlewi @yebrahim

@jlewi
Copy link
Contributor

jlewi commented Aug 9, 2018

What is the reasoning behind deciding which RPCs to expose?

Why not simply expose a high level function that performs all the needed steps?

If you look at kfctl.sh
https://github.com/kubeflow/kubeflow/blob/master/scripts/gke/README.md

There are two commands
generate - creates the configs
apply - applies the config (calls DM, creates service accounts, creates secrets, calls ks apply etc...).

Why not just have two similar RPCs? And treat specific RPCs (like role bindings as internal RPCs).

@kunmingg
Copy link
Contributor Author

kunmingg commented Aug 9, 2018

@jlewi
We'll have the 2 high level handler you mentioned.
But this one is necessary because without editing IAM first (through user's token), deployment manager as a service, don't have sufficient permission to edit project IAM.

@kunmingg
Copy link
Contributor Author

kunmingg commented Aug 9, 2018

/retest

2 similar comments
@kunmingg
Copy link
Contributor Author

kunmingg commented Aug 9, 2018

/retest

@kunmingg
Copy link
Contributor Author

/retest

@jlewi
Copy link
Contributor

jlewi commented Aug 10, 2018

/lgtm
/approve

@jlewi
Copy link
Contributor

jlewi commented Aug 10, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cbc1c06 into kubeflow:master Aug 10, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* add bindRoleHandler which bind roles to service accounts

* handle review feedback: give more high level handler
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
* Upload 0.0.4 SDK version

* Fix doc links

* Fix links in README

* Modify tables

* Fix link

* Remove

* Modify client and gen script

* Update version to 0.0.5

* Run CI

* Add Katib client to init
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants