-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gcp] Enable new stackdriver Kubernetes agents on GKE #1757
Comments
I think this might need a little bit more work. It looks like its guarded by gkeApiVersion
We just need to test it and then maybe document it. |
/remove-priority p1 |
/priority p1 |
It looks like the feature is still in beta. Beta features are only available through the v1beta1 API So we need to use that API to create/modify the cluster. |
* We want to enable the stackdriver monitoring agents by default. This allows pod logs to be fetched by pod label which is very valuable. * To enable this we need to use the v1beta1 API for GKE https://cloud.google.com/kubernetes-engine/docs/reference/api-organization#beta * Remove the field CLUSTER_VERSION from kfctl.sh This was added in kubeflow#1888 but it doesn't look like it was actually being use to set the CLUSTER_VERSION; it looks like cluster-version is set in the deployment manager config cluster-kubeflow.yaml Related to kubeflow#1757
* We want to enable the stackdriver monitoring agents by default. This allows pod logs to be fetched by pod label which is very valuable. * To enable this we need to use the v1beta1 API for GKE https://cloud.google.com/kubernetes-engine/docs/reference/api-organization#beta * Remove the field CLUSTER_VERSION from kfctl.sh This was added in #1888 but it doesn't look like it was actually being use to set the CLUSTER_VERSION; it looks like cluster-version is set in the deployment manager config cluster-kubeflow.yaml Related to #1757
Confirmed on https://kf-v0-4-n00.endpoints.kubeflow-ci.cloud.goog/ that new stackdriver agents are deployed. that we are now enabling the new stackedriver agents and that Using the query
Response
|
* We want to enable the stackdriver monitoring agents by default. This allows pod logs to be fetched by pod label which is very valuable. * To enable this we need to use the v1beta1 API for GKE https://cloud.google.com/kubernetes-engine/docs/reference/api-organization#beta * Remove the field CLUSTER_VERSION from kfctl.sh This was added in kubeflow#1888 but it doesn't look like it was actually being use to set the CLUSTER_VERSION; it looks like cluster-version is set in the deployment manager config cluster-kubeflow.yaml Related to kubeflow#1757
To enable the new agents I think we need to set the following in our cluster DM config.
We can verify its enabled in the Cloud console where it should say
The text was updated successfully, but these errors were encountered: