-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MetricsReporter fails on nil
nodeStatus.Status
#334
Comments
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! |
Issue Label Bot is not confident enough to auto-label this issue. |
done |
@Tomcli: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind bug
What steps did you take and what happened:
In some failure scenarios the
Status
inPipelineRunTaskRunStatus
can benil
.collectNodeMetricsOrNil
is unsafe and crashes.What did you expect to happen:
This corner case should be ignored.
Additional information:
N/A
Environment:
python --version
):tkn version
):kubectl version
):/etc/os-release
):The text was updated successfully, but these errors were encountered: