Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new-ui] Bump angular version to 12 #1712

Merged
merged 27 commits into from
Jan 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
f60a10b
update README.md
seong7 Sep 3, 2021
a6d6778
npm install
seong7 Sep 5, 2021
c2b51a2
version up : Angular 8 -> 9 / TS 3.5 -> 3.8
seong7 Sep 8, 2021
02a5724
version up: angular material 9
seong7 Sep 8, 2021
6abc58d
remove deprecated entryComponents
seong7 Sep 8, 2021
ded5d7a
edit depricated testBed.get -> testBed.inject
seong7 Sep 8, 2021
a48d431
Version up : @angular/core@10 /cli@10
seong7 Sep 23, 2021
f64744c
Version up : @angular/cdk, @angular/material 9 -> 10
seong7 Sep 23, 2021
f749888
Version up : @angular/cdk-experimental 8 -> 10
seong7 Sep 23, 2021
b8b1ca5
dependency version up : @fortawesome/angular-fontawesome (0.5.0 -> 0.…
seong7 Sep 28, 2021
aec6a14
dependency version up : @swimlane/ngx-charts (13.0.4 -> 16.0.0)
seong7 Sep 28, 2021
18ed399
ng update @angular/core@11 @angular/cli@11
seong7 Sep 28, 2021
884da97
ng update @angular/material@11
seong7 Sep 28, 2021
b4b478f
npm install @angular/[email protected]
seong7 Sep 28, 2021
d1ff6c5
ng update @angular/core@12 @angular/cli@12
seong7 Sep 28, 2021
498ac5e
npm install @fortawesome/[email protected]
seong7 Sep 28, 2021
263cc99
ng update @angular/material
seong7 Sep 28, 2021
216d1b0
npm install @angular/[email protected]
seong7 Sep 28, 2021
2afeae3
npm install @swimlane/[email protected]
seong7 Sep 28, 2021
91dd0e4
remvoe error line from @angular/compiler
seong7 Sep 28, 2021
9b85e8b
npm install @angular/[email protected]
seong7 Oct 13, 2021
45e78f8
pull master
seong7 Oct 13, 2021
82b1f2e
run format:write
seong7 Oct 13, 2021
2b6cd91
Edit Dockerfile
seong7 Nov 5, 2021
b231bab
Rollback package-lock.json version to 1
seong7 Dec 14, 2021
66e4fce
Update README.md
seong7 Dec 14, 2021
e8983ed
remove assets/fonts by gitignore
seong7 Jan 13, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/new-ui/v1beta1/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ RUN apt-get update && apt-get install git -y
WORKDIR /kf
RUN git clone https://github.com/kubeflow/kubeflow.git && \
cd kubeflow && \
git checkout 24bcb8e
git checkout ecb72c2

# --- Build the frontend kubeflow library ---
FROM node:12 AS frontend-kubeflow-lib
Expand Down
4 changes: 2 additions & 2 deletions pkg/new-ui/v1beta1/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ To make changes to the UI you need to install:

- Tools, defined [here](https://github.com/kubeflow/katib/blob/master/docs/developer-guide.md#requirements).

- `node` (v12 or later) and `npm` (v6.13 or later). Recommended to install `node` and `npm` using [`nvm`](https://github.com/nvm-sh/nvm). After installing `nvm`, you can run `nvm install 12.18.1` to install `node` version 12.18.1 and run `nvm use 12.18.1` to use that version.
- `node` (v12.18.1) and `npm` (v6.13). Recommended to install `node` and `npm` using [`nvm`](https://github.com/nvm-sh/nvm). After installing `nvm`, you can run `nvm install 12.18.1` to install `node` version 12.18.1 and run `nvm use 12.18.1` to use that version.

## Development

Expand All @@ -42,7 +42,7 @@ You can build the common library with:
```bash
cd /tmp && git clone https://github.com/kubeflow/kubeflow.git \
&& cd kubeflow \
&& git checkout 24bcb8e \
&& git checkout ecb72c2 \
&& cd components/crud-web-apps/common/frontend/kubeflow-common-lib

# build the common library module
Expand Down
3 changes: 3 additions & 0 deletions pkg/new-ui/v1beta1/frontend/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,6 @@ Thumbs.db

# Rok files
**/browse-in-rok*

# Font files (automatically generating)
/src/assets/fonts
14 changes: 9 additions & 5 deletions pkg/new-ui/v1beta1/frontend/angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,20 @@
"main": "src/main.ts",
"polyfills": "src/polyfills.ts",
"tsConfig": "tsconfig.app.json",
"aot": false,
"assets": ["src/favicon.ico", "src/assets"],
"styles": ["src/styles.scss", "src/assets/css/d3.parcoords.css"],
"scripts": [
"node_modules/d3/d3.js",
"node_modules/ace-builds/src-min/ace.js",
"node_modules/ace-builds/src-min/mode-yaml.js",
"node_modules/ace-builds/src-min/theme-xcode.js"
]
],
"vendorChunk": true,
"extractLicenses": false,
"buildOptimizer": false,
"sourceMap": true,
"optimization": false,
"namedChunks": true
},
"configurations": {
"production": {
Expand All @@ -44,9 +49,7 @@
"optimization": true,
"outputHashing": "all",
"sourceMap": false,
"extractCss": true,
"namedChunks": false,
"aot": true,
"extractLicenses": true,
"vendorChunk": false,
"buildOptimizer": true,
Expand All @@ -63,7 +66,8 @@
}
]
}
}
},
"defaultConfiguration": ""
},
"serve": {
"builder": "@angular-devkit/build-angular:dev-server",
Expand Down
2 changes: 1 addition & 1 deletion pkg/new-ui/v1beta1/frontend/e2e/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"compilerOptions": {
"outDir": "../out-tsc/e2e",
"module": "commonjs",
"target": "es5",
"target": "es2018",
"types": [
"jasmine",
"jasminewd2",
Expand Down
Loading