Add kubeflow/kubeflow repo into third-party-bots #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aut0R3V
approved these changes
Jan 5, 2021
|
/cc @Bobgy Can you help review? Let me know if any concerns |
|
@kubeflow/wg-notebooks-leads Can anyone comment here to say we're in an agreement to move forward with the current PR? |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Aut0R3V, Bobgy, PatrickXYS The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 tasks
zijianjoy
pushed a commit
to zijianjoy/internal-acls
that referenced
this pull request
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of kubeflow/kubeflow#5482
We discussed with @kubeflow/wg-notebooks-leads in the issue, and agreed to add kubeflow/kubeflow repo write access to third-party-bots, by merging this PR, we'll be able to set up CI for kubeflow/kubeflow on Optional-Test-Infra.
/cc @Bobgy
/cc @kubeflow/wg-notebooks-leads