Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNCF Code of Conduct migration plan #614

Closed
kimwnasptd opened this issue Mar 7, 2023 · 11 comments · Fixed by #658
Closed

CNCF Code of Conduct migration plan #614

kimwnasptd opened this issue Mar 7, 2023 · 11 comments · Fixed by #658

Comments

@kimwnasptd
Copy link
Member

Hi everyone, was taking a look with @akgraner on the transition requirements and we took a more detailed look on the changes that we need to make regarding the Code of Conduct.

I'm going to expose my findings by explaining what is (to my best understanding) the current state of Kubeflow, what are other CNCF projects, like Argo, doing and lastly what are some potential next steps for Kubeflow.

@jbottum @theadactyl @james-jwu my goal is to expose in a single place this context to help us decide on next steps. Looking forward to your feedback!

@kimwnasptd
Copy link
Member Author

Kubeflow CoC

Kubeflow currently has it's own Code of Conduct, which seems to be a mixture of https://www.contributor-covenant.org/version/1/4/code-of-conduct/ and Google's Open Source Community Guidelines.

Aside from the https://github.com/kubeflow/community/blob/master/CODE_OF_CONDUCT.md file, in the community repo, in the Kubeflow Org there are also CONTRIBUTING.md files in the following places:

  1. https://github.com/kubeflow/community/blob/master/CONTRIBUTING.md
  2. https://github.com/kubeflow/kubeflow/blob/master/CONTRIBUTING.md
  3. https://github.com/kubeflow/pipelines/blob/master/CONTRIBUTING.md
  4. https://github.com/kubeflow/mpi-operator/blob/master/CONTRIBUTING.md

I'm mentioning the CONTRIBUTING.md files since, from what I understand, it's a common place for exposing contributing guidelines and the CoC in these files.

@kimwnasptd
Copy link
Member Author

Other CNCF Projects (Argo)

Argo has the following files:

  1. No Code of Conduct file, since they are using CNCF's
  2. A CONTRIBUTING.md file in their community repo, that points to the CNCF CoC https://github.com/argoproj/argoproj/blob/master/community/CONTRIBUTING.md
  3. No other CONTRIBUTING.md file in the other repos of their GH Org https://github.com/argoproj

IMHO just because Argo is doing this doesn't mean we have to blindly do the same. But it was helpful for me to get an understanding of how other communities approach this, and that's why I exposed the above

@kimwnasptd
Copy link
Member Author

Next steps for Kubeflow

The first immediate change that we can do is to update the contributing guidelines in the website to point to CNCF's CoC, instead of Kubeflow's current one https://www.kubeflow.org/docs/about/contributing/#follow-the-code-of-conduct

Then we'll need to make some decisions regarding the current CoC file we have in Kubeflow and the CONTRIBUTING.md files.

Regarding the current CoC file in Kubeflow:

  • Option A: Remove this file altogether and point to CNCF CoC from community's CONTRIBUTING.md file, like they do for Argo
  • Option B: Keep that file but just change it to point to CNCF CoC

Regarding the CONTRIBUTING.md files:

  • Option A: Each repo can have its own, but all should have a section pointing to the CNCF CoC
  • Option B: Single file for the whole GH Org, living in the community repo

@kimwnasptd
Copy link
Member Author

Hope the above summary will help to ensure all of us are in the same page. If you think there are other steps I missed feel free to point them out so that we can have a definitive list of items we need to track.

@theadactyl
Copy link
Contributor

theadactyl commented Mar 7, 2023 via email

@akgraner
Copy link
Contributor

@theadactyl we understand that we can't adopt the CNCF COC yet; however, we need to decide on where we want to list the COC and come up with a standard on how/where we list the COC going forward. Thanks.

This is also another point where going to Sandbox instead of straight to Incubation makes more sense, so we are part of the CNCF then we can make these changes sooner (but I digress and should probably open another issue on this point.) CC: @kimwnasptd

@jbottum
Copy link
Contributor

jbottum commented Mar 13, 2023

@kimwnasptd thanks for putting this together. Per your questions, I like a single file that points to the CNCF CoC. IMO, we should get this ready to go (as part of our Due Diligence). I propose this could mean voting on the options that you laid out, and then creating/putting a PR /hold (so that it is pre-approved when the transition occurs).

All - Please identify your position below (+1 might be easiest if you approve this option). Thanks.

Regarding the current CoC file in Kubeflow:
Option A: Remove this file altogether and point to CNCF CoC from community's CONTRIBUTING.md file, like they do for Argo

Regarding the CONTRIBUTING.md files:
Option B: Single file for the whole GH Org, living in the community repo

@kimwnasptd kimwnasptd changed the title CFCF Code of Conduct migration plan CNCF Code of Conduct migration plan Mar 14, 2023
@james-jwu
Copy link
Contributor

+1 to Option A. I don't see a clear need to have a copy of CNCF CoC, which we could do later if needs arise.

@theadactyl
Copy link
Contributor

Slight preference to following k8s example here by modifying our existing code of conduct file: https://github.com/kubernetes/community/blob/master/code-of-conduct.md It is fairly standard to have a separate CoC file, and that way we wouldn't break any links. Also, contributors aren't the only folks bound to the Code of Conduct, so having it be more visible/discoverable as its a standalone pointer file in /community would be better IMO.

@terrytangyuan
Copy link
Member

+1 to @theadactyl's proposal above

@annajung
Copy link
Member

annajung commented Nov 7, 2023

Hi all, a PR #658 is open to update Kubeflow's CoC to CNCF's CoC. Based on the comments above, I kept the Kubeflow CoC doc and modified the content to point to CNCF's CoC.

As for CONTRIBUTING.md, this doc contains information about how one can get started in contributing to Kubeflow. It also contains a pointer to https://www.kubeflow.org/docs/about/contributing/ which has reference to CoC, but I don't think this doc should be deleted especially for MPI-operator and Pipelines WG who have added repo-specific setup into the doc.

Instead, I think we should allow each repo to have it's own as long as it has a reference to https://www.kubeflow.org/docs/about/contributing. This means, only one CONTRIBUTING.md under Pipelines repo needs to be modified to include a pointer to https://www.kubeflow.org/docs/about/contributing/ similar to https://github.com/kubeflow/mpi-operator/blob/master/CONTRIBUTING.md

cc pipelines WG @zijianjoy @chensun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants