Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstructured lifelong learning with cloud robotics example #382

Merged
merged 12 commits into from
Dec 29, 2022
Merged

Unstructured lifelong learning with cloud robotics example #382

merged 12 commits into from
Dec 29, 2022

Conversation

luosiqi
Copy link
Contributor

@luosiqi luosiqi commented Dec 8, 2022

No description provided.

@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 8, 2022
jaypume
jaypume reviewed Dec 13, 2022
View reviewed changes
examples/lifelong_learning/robot_dog_delivery/RFNet/predict.py Outdated


if __name__ == '__main__':
print(predict())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following images under ramp directory should be moved to net drive instead of commiting here, if it is really needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

MooreZheng
MooreZheng reviewed Dec 13, 2022
View reviewed changes
examples/lifelong_learning/robot_dog_delivery/RFNet/predict.py Outdated
}
}

# unseen_sample_recognition = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean unnecessary code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

MooreZheng
MooreZheng reviewed Dec 13, 2022
View reviewed changes
lib/sedna/algorithms/seen_task_learning/task_relation_discover/task_relation_discover.py Outdated

"""
Discover relationships between all tasks

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

task_relation_discover -> task_relation_discovery

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

MooreZheng
MooreZheng reviewed Dec 13, 2022
View reviewed changes
lib/sedna/algorithms/knowledge_management/task_evaluation/task_evaluation.py Outdated
from sedna.common.log import LOGGER
from sedna.common.class_factory import ClassType, ClassFactory

__all__ = ('TaskEvaluationDefault', )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add BaseClass / Interface

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not finished yet.

MooreZheng
MooreZheng reviewed Dec 13, 2022
View reviewed changes
lib/sedna/algorithms/knowledge_management/task_update_decision/task_update_decision.py Outdated
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add BaseClass / Interface

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not finished yet.

MooreZheng
MooreZheng reviewed Dec 13, 2022
View reviewed changes
lib/sedna/service/server/knowledgeBase/server.py
@@ -28,6 +28,7 @@
from sedna.service.server.base import BaseServer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name changed to knowledgeBaseServer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decide to not change the name

luosiqi
luosiqi commented Dec 13, 2022
View reviewed changes
lib/sedna/service/server/knowledgeBase/server.py
@@ -28,6 +28,7 @@
from sedna.service.server.base import BaseServer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is added?

Copy link
Contributor Author

@luosiqi luosiqi Dec 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not finish yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

lib/sedna/algorithms/knowledge_management/base_knowledge_management.py Outdated
self.task_group_key = KBResourceConstant.TASK_GROUPS.value
self.extractor_key = KBResourceConstant.EXTRACTOR.value

self.kb_server = KBClient(kbserver=self.config.ll_kb_server)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kb_server -> kb_client

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

lib/sedna/algorithms/knowledge_management/base_knowledge_management.py Outdated
@@ -0,0 +1,28 @@
from sedna.backend import set_backend
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put them under core/lifelong_learning

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

MooreZheng
MooreZheng reviewed Dec 13, 2022
View reviewed changes
lib/sedna/algorithms/knowledge_management/task_update_decision/task_update_decision.py Outdated
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment to explain why update decision is needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

MooreZheng
MooreZheng reviewed Dec 13, 2022
View reviewed changes
lib/sedna/algorithms/knowledge_management/task_evaluation/task_evaluation.py Outdated
from sedna.common.config import Context
from sedna.common.log import LOGGER
from sedna.common.class_factory import ClassType, ClassFactory

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment to explain why task evaluation is needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@luosiqi
Copy link
Contributor Author

luosiqi commented Dec 28, 2022

Future work:

  1. Add base class of algorithm modules
  2. Add docs
  3. Dataset of this example
  4. Add annotations of server.py

@MooreZheng
Copy link

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 29, 2022
@jaypume
Copy link
Member

jaypume commented Dec 29, 2022

/lgtm

@jaypume
Copy link
Member

jaypume commented Dec 29, 2022

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypume

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2022
@kubeedge-bot kubeedge-bot merged commit 1cddd17 into kubeedge:main Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MooreZheng MooreZheng MooreZheng left review comments

@jaypume jaypume jaypume left review comments

@llhuii llhuii Awaiting requested review from llhuii

@TymonXie TymonXie Awaiting requested review from TymonXie

Assignees

@jaypume jaypume

@MooreZheng MooreZheng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luosiqi @MooreZheng @jaypume @kubeedge-bot