Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSPP]The proposal for TinyMS support in Python SDK #341

Merged
merged 1 commit into from
Oct 31, 2022
Merged

[OSPP]The proposal for TinyMS support in Python SDK #341

merged 1 commit into from
Oct 31, 2022

Conversation

Lj1ang
Copy link
Contributor

@Lj1ang Lj1ang commented Aug 1, 2022 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does:
This PR is a proposal that analyses Python SDK architecture of sedna and discusses the way to implement Python SDK support for TinyMS and demos of MindSpore and TinyMS

Fixes #307

@kubeedge-bot kubeedge-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 1, 2022
@kubeedge-bot
Copy link
Collaborator

Welcome @Lj1ang! It looks like this is your first PR to kubeedge/sedna 🎉

@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 1, 2022
@Lj1ang Lj1ang changed the title [Doc]OSPP proposal [OSPP]The proposal for TinyMS support in Python SDK Aug 1, 2022
@Lj1ang Lj1ang closed this Aug 1, 2022
@Lj1ang Lj1ang reopened this Aug 1, 2022
@Lj1ang Lj1ang force-pushed the TinyMS-Support-and-Demos branch from d1b1204 to 545bd85 Compare August 1, 2022 05:13
@kubeedge-bot kubeedge-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2022
jaypume
jaypume requested changes Aug 9, 2022
View reviewed changes
docs/proposals/tinyms-support.md Outdated Show resolved Hide resolved
docs/proposals/tinyms-support.md Outdated Show resolved Hide resolved
docs/proposals/tinyms-support.md Outdated Show resolved Hide resolved
@Lj1ang Lj1ang requested a review from jaypume August 9, 2022 04:16
@kubeedge-bot kubeedge-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 12, 2022
@Lj1ang Lj1ang force-pushed the TinyMS-Support-and-Demos branch from 111749a to 2780e31 Compare September 28, 2022 03:24
@kubeedge-bot kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 28, 2022
jaypume
jaypume reviewed Oct 14, 2022
View reviewed changes
docs/proposals/tinyms-support.md Outdated
@@ -0,0 +1,144 @@
- [Implement Sedna Python SDK support TinyMS](#mplement Sedna Python SDK support TinyMS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows error link when preview. Please fix it to make it preview correctly.
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like that IDE is a little different from github in markdown.
I have fixed this error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index looks fine to me now

@Lj1ang Lj1ang force-pushed the TinyMS-Support-and-Demos branch from 1f71a6b to 1113080 Compare October 14, 2022 11:05
@Lj1ang Lj1ang requested review from jaypume and removed request for JimmyYang20 and TymonXie October 14, 2022 15:16
@MooreZheng
Copy link
Contributor

The goals should highlight the benefit of mindspore, e.g., TinyMS, for the KubeEdge Community of SIG AI.

@Poorunga
Copy link
Member

/lgtm

@kubeedge-bot kubeedge-bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Oct 18, 2022
@Lj1ang
Copy link
Contributor Author

Lj1ang commented Oct 18, 2022

The goals should highlight the benefit of mindspore, e.g., TinyMS, for the KubeEdge Community of SIG AI.

Added

@jaypume
Copy link
Member

jaypume commented Oct 25, 2022

The goals should highlight the benefit of mindspore, e.g., TinyMS, for the KubeEdge Community of SIG AI.

Added

I think more concret benifit can be put here, and you can refer to this page:
https://tinyms.readthedocs.io/en/latest/quickstart/overview.html#tinyms-project

@Lj1ang
Copy link
Contributor Author

Lj1ang commented Oct 25, 2022

The goals should highlight the benefit of mindspore, e.g., TinyMS, for the KubeEdge Community of SIG AI.

Added

I think more concret benifit can be put here, and you can refer to this page: https://tinyms.readthedocs.io/en/latest/quickstart/overview.html#tinyms-project

Added more concrete benefits.

@Lj1ang Lj1ang force-pushed the TinyMS-Support-and-Demos branch from ba3600e to b82116b Compare October 28, 2022 05:29
@Lj1ang Lj1ang changed the base branch from main to ct-park-poc October 28, 2022 05:37
@Lj1ang Lj1ang changed the base branch from ct-park-poc to main October 28, 2022 05:37
@Lj1ang Lj1ang force-pushed the TinyMS-Support-and-Demos branch from b82116b to 702fb8c Compare October 28, 2022 05:41
@jaypume
Copy link
Member

jaypume commented Oct 31, 2022

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2022
jaypume
jaypume reviewed Oct 31, 2022
View reviewed changes
Copy link
Member

@jaypume jaypume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me now.

@jaypume
Copy link
Member

jaypume commented Oct 31, 2022

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypume

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2022
@kubeedge-bot kubeedge-bot merged commit ebfdbfa into kubeedge:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MooreZheng MooreZheng MooreZheng left review comments

@jaypume jaypume jaypume requested changes

Assignees

@jaypume jaypume

@Poorunga Poorunga

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Implement Sedna Python SDK support for MindSpore and TinyMS
5 participants
@Lj1ang @kubeedge-bot @MooreZheng @Poorunga @jaypume