Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docs: index and quickstart #233

Merged
merged 2 commits into from
Dec 31, 2021
Merged

fix docs: index and quickstart #233

merged 2 commits into from
Dec 31, 2021

Conversation

jaypume
Copy link
Member

@jaypume jaypume commented Nov 10, 2021

Signed-off-by: Jie Pu [email protected]

@kubeedge-bot kubeedge-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 10, 2021
@jaypume
Copy link
Member Author

jaypume commented Nov 11, 2021

/hold

@kubeedge-bot kubeedge-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2021
@jaypume jaypume force-pushed the docs branch 10 times, most recently from 9806782 to 1578174 Compare November 12, 2021 15:11
@jaypume
Copy link
Member Author

jaypume commented Dec 29, 2021

/approve

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2021
@jaypume
Copy link
Member Author

jaypume commented Dec 30, 2021

/unhold

@kubeedge-bot kubeedge-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 30, 2021
@jaypume
Copy link
Member Author

jaypume commented Dec 30, 2021

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypume

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaypume
Copy link
Member Author

jaypume commented Dec 30, 2021

/lgtm

@kubeedge-bot
Copy link
Collaborator

@jaypume: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MooreZheng
Copy link

/lgtm

@kubeedge-bot
Copy link
Collaborator

@MooreZheng: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JimmyYang20
Copy link

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 31, 2021
@kubeedge-bot kubeedge-bot merged commit 397b5e5 into kubeedge:main Dec 31, 2021
@MooreZheng
Copy link

Talked to Pujie previously with 16 comments on the index and quickstart. Modifications have been made in this commit.

@MooreZheng MooreZheng mentioned this pull request May 5, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimmyYang20 JimmyYang20 Awaiting requested review from JimmyYang20

@TymonXie TymonXie Awaiting requested review from TymonXie

Assignees

@JimmyYang20 JimmyYang20

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaypume @kubeedge-bot @MooreZheng @JimmyYang20