Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage initializer: keep dir name in s3 download #221

Merged
merged 1 commit into from
Oct 29, 2021
Merged

storage initializer: keep dir name in s3 download #221

merged 1 commit into from
Oct 29, 2021

Conversation

JimmyYang20
Copy link

@JimmyYang20 JimmyYang20 commented Oct 27, 2021 •
edited
Loading

support download folders

Signed-off-by: JimmyYang20 [email protected]

@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 27, 2021
@JimmyYang20 JimmyYang20 force-pushed the fixbug-init-container branch 2 times, most recently from a9d6645 to 1f4cca7 Compare October 28, 2021 02:00
@JimmyYang20 JimmyYang20 force-pushed the fixbug-init-container branch from 1f4cca7 to 1c5c537 Compare October 28, 2021 09:26
@JimmyYang20 JimmyYang20 reopened this Oct 28, 2021
@kubeedge-bot kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2021
@JimmyYang20 JimmyYang20 changed the title fix DownloadDstDir bug fix s3 download Oct 28, 2021
@JimmyYang20 JimmyYang20 force-pushed the fixbug-init-container branch from 5cf3de1 to 9300d59 Compare October 28, 2021 11:38
@JimmyYang20 JimmyYang20 changed the title fix s3 download storage initializer: fix s3 download Oct 28, 2021
@JimmyYang20 JimmyYang20 force-pushed the fixbug-init-container branch from 9300d59 to 4675eaa Compare October 28, 2021 13:16
@JimmyYang20
Copy link
Author

/hold

@kubeedge-bot kubeedge-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2021
@llhuii
Copy link

llhuii commented Oct 29, 2021

need to update README, https://github.com/kubeedge/sedna/tree/main/scripts/storage-initializer#usage

llhuii
llhuii reviewed Oct 29, 2021
View reviewed changes
scripts/storage-initializer/download.py Outdated
bucket_args = uri.replace(_S3_PREFIX, "", 1).split("/", 1)
# download all(files, folders) in s3
# when downloading the specified file, keep the name of the file itself.
# when downloading the specified folder, keep the name of the folder itself.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use docstring for commenting function

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, fix it

@JimmyYang20 JimmyYang20 force-pushed the fixbug-init-container branch from 4675eaa to 337dcd4 Compare October 29, 2021 03:23
@JimmyYang20
Copy link
Author

need to update README, https://github.com/kubeedge/sedna/tree/main/scripts/storage-initializer#usage

has been updated it

@JimmyYang20
Copy link
Author

/unhold

@kubeedge-bot kubeedge-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2021
@JimmyYang20 JimmyYang20 force-pushed the fixbug-init-container branch 2 times, most recently from ccb066a to ff3930d Compare October 29, 2021 08:57
@JimmyYang20 JimmyYang20 changed the title storage initializer: fix s3 download storage initializer: keep dir name if s3 download Oct 29, 2021
@JimmyYang20 JimmyYang20 force-pushed the fixbug-init-container branch from ff3930d to fd7caec Compare October 29, 2021 09:47
@kubeedge-bot kubeedge-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2021
storage initializer: keep dir name in s3 download
17cbfc1 
when downloading the specified folder, keep the name of the folder itself.

Signed-off-by: JimmyYang20 <[email protected]>
@JimmyYang20 JimmyYang20 force-pushed the fixbug-init-container branch from fd7caec to 17cbfc1 Compare October 29, 2021 09:52
@JimmyYang20 JimmyYang20 changed the title storage initializer: keep dir name if s3 download storage initializer: keep dir name in s3 download Oct 29, 2021
@llhuii
Copy link

llhuii commented Oct 29, 2021

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2021
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: llhuii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2021
@kubeedge-bot kubeedge-bot merged commit b1ec13e into kubeedge:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llhuii llhuii llhuii left review comments

@jaypume jaypume Awaiting requested review from jaypume

@TymonXie TymonXie Awaiting requested review from TymonXie

Assignees

@llhuii llhuii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JimmyYang20 @llhuii @kubeedge-bot