Add object search controller #190

EnfangCui · 2021-09-09T06:50:23Z

Add the object search controller to GM

The user worker and ReID workers can be created on both cloud and edge. ( EdgeMesh v1.8 supports cross edge-cloud communication.)

TymonXie · 2021-09-09T08:43:52Z

pkg/globalmanager/controllers/objectsearch/objectsearchservice.go

+	objectSearchUserWorker     = "userworker"
+	objectSearchTrackingWorker = "trackingworker"
+	objectSearchReidWorker     = "reidworker"
+	reidPort                   = 9378


it means reid service port?

Yes. I changed it to reidServicePort.

TymonXie · 2021-09-09T08:53:42Z

pkg/globalmanager/controllers/objectsearch/objectsearchservice.go

+	c.enqueueController(service, immediate)
+}
+
+//When a deployment is created, enqueue the controller that manages it and update it's expectations.


leave a space after '//'

TymonXie · 2021-09-09T08:53:55Z

pkg/globalmanager/controllers/objectsearch/objectsearchservice.go

+	c.enqueueByDeployment(deployment, true)
+}
+
+//deleteDeployment enqueues the ObjectSearchService obj When a deleteDeployment is deleted


same problem

TymonXie · 2021-09-09T09:23:46Z

pkg/globalmanager/controllers/objectsearch/objectsearchservice.go

+	var reason string
+	var message string
+
+	if podFailed > 0 || deploymentFailed > 0 {


might can use switch-case instead of if-else

Changed to switch-case.

llhuii · 2021-09-14T08:12:11Z

pkg/globalmanager/controllers/objectsearch/downstream.go

+	"github.com/kubeedge/sedna/pkg/globalmanager/runtime"
+)
+
+// func (c *Controller) syncToEdge(eventType watch.EventType, obj interface{}) error {


Remove these comment codes

Removed and add TODO tag.

Look like commented code not removed

llhuii · 2021-09-14T08:14:39Z

pkg/globalmanager/controllers/objectsearch/downstream.go

+// 	return c.sendToEdgeFunc(nodeName, eventType, joint)
+// }
+
+func (c *Controller) SetDownstreamSendFunc(f runtime.DownstreamSendFunc) error {


Add some comment or TODO to explain that no need sync the object search service info to edge nodes(i.e. Local Controller).

llhuii · 2021-09-14T08:28:15Z

pkg/globalmanager/controllers/objectsearch/upstream.go

+*/
+
+// updateFromEdge syncs the edge updates to k8s
+func (c *Controller) updateFromEdge(name, namespace, operation string, content []byte) error {


updateFromEdge can not be called since no update from LC.
Recommended that remove this untested implemention, and add a TODO comment.

Removed and add TODO comment.

llhuii · 2021-09-14T08:32:38Z

pkg/globalmanager/runtime/worker.go

@@ -170,6 +180,107 @@ func CreatePodWithTemplate(client kubernetes.Interface, object CommonInterface,
 	return createdPod, nil
 }

+//CreateEdgeMeshService creates a kubeedge edgemesh service for an object, and returns an edgemesh service URL.
+//Since edgemesh can realize Cross-Edge-Cloud communication, the service can be created both on the cloud or edge side.
+func CreateEdgeMeshService(kubeClient kubernetes.Interface, object CommonInterface, workerType string, inputPort int32) (string, error) {


What is the difference between CreateEdgeMeshService and CreateKubernetesService? I can't see it.

There are three main differences:

ObjectMeta uses Name instead of GenerateName because it relates to the URL returned.

A fixed format URL needs to be returned.

Port Name is required.

OK. You can extend CreateKubernetesService to support these differences.

llhuii · 2021-09-14T08:33:47Z

pkg/globalmanager/runtime/worker.go

@@ -170,6 +180,107 @@ func CreatePodWithTemplate(client kubernetes.Interface, object CommonInterface,
 	return createdPod, nil
 }

+//CreateEdgeMeshService creates a kubeedge edgemesh service for an object, and returns an edgemesh service URL.


Add extra a space after //, same with other places.

Suggested change

//CreateEdgeMeshService creates a kubeedge edgemesh service for an object, and returns an edgemesh service URL.

// CreateEdgeMeshService creates a kubeedge edgemesh service for an object, and returns an edgemesh service URL.

Signed-off-by: EnfangCui <[email protected]>

Signed-off-by: Yutong Wang <[email protected]>

Signed-off-by: HenryChou <[email protected]>

Signed-off-by: DanLiu <[email protected]>

…troller Signed-off-by: ShiXiaohou <[email protected]>

llhuii · 2021-09-24T01:25:23Z

/lgtm

llhuii · 2021-09-24T01:31:37Z

/approve
Thanks @EnfangCui

kubeedge-bot · 2021-09-24T01:31:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: llhuii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/globalmanager/OWNERS~~ [llhuii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubeedge-bot requested review from jaypume and TymonXie September 9, 2021 06:50

kubeedge-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 9, 2021

TymonXie reviewed Sep 9, 2021

View reviewed changes

llhuii reviewed Sep 14, 2021

View reviewed changes

Add object-search controller to \pkg\globalmanager\controllers

76c79d1

Signed-off-by: EnfangCui <[email protected]>

EnfangCui force-pushed the add-object-search-controller branch from b6dbaf4 to 76c79d1 Compare September 22, 2021 07:52

Ratuchetp and others added 3 commits September 22, 2021 16:44

Add func to create reid worker and service to object-search controller

59d639e

Signed-off-by: Yutong Wang <[email protected]>

Add func to create user worker to object-search controller

45aebc3

Signed-off-by: HenryChou <[email protected]>

Add func to create user worker service to object-search controller

ac4cf2e

Signed-off-by: DanLiu <[email protected]>

EnfangCui force-pushed the add-object-search-controller branch from 394de29 to e25fe23 Compare September 23, 2021 14:20

Add function about creating tracking worker pods to object-search con…

ff28a1e

…troller Signed-off-by: ShiXiaohou <[email protected]>

EnfangCui force-pushed the add-object-search-controller branch from e25fe23 to ff28a1e Compare September 23, 2021 14:41

kubeedge-bot assigned llhuii Sep 24, 2021

kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2021

kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2021

kubeedge-bot merged commit 3d88d0d into kubeedge:main Sep 24, 2021

This was referenced Oct 29, 2021

Add a github action for checking generated CRDs files #224

Open

Add missing object search/tracking CRD and RBAC yamls #223

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add object search controller #190

Add object search controller #190

EnfangCui commented Sep 9, 2021 •

edited

Loading

TymonXie Sep 9, 2021

EnfangCui Sep 22, 2021

TymonXie Sep 9, 2021

EnfangCui Sep 22, 2021

TymonXie Sep 9, 2021

TymonXie Sep 9, 2021

EnfangCui Sep 22, 2021

llhuii Sep 14, 2021

EnfangCui Sep 22, 2021

llhuii Sep 22, 2021

llhuii Sep 14, 2021

llhuii Sep 14, 2021

EnfangCui Sep 22, 2021

llhuii Sep 14, 2021

EnfangCui Sep 22, 2021

llhuii Sep 22, 2021

llhuii Sep 14, 2021

EnfangCui Sep 22, 2021

llhuii commented Sep 24, 2021

llhuii commented Sep 24, 2021

kubeedge-bot commented Sep 24, 2021

	//CreateEdgeMeshService creates a kubeedge edgemesh service for an object, and returns an edgemesh service URL.
	// CreateEdgeMeshService creates a kubeedge edgemesh service for an object, and returns an edgemesh service URL.

Add object search controller #190

Add object search controller #190

Conversation

EnfangCui commented Sep 9, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

llhuii commented Sep 24, 2021

llhuii commented Sep 24, 2021

kubeedge-bot commented Sep 24, 2021

EnfangCui commented Sep 9, 2021 •

edited

Loading