Add SchemaRegistry with RestProxy API (#1372)

* Add SchemaRegistry with RestProxy API Signed-off-by: obaydullahmhs <[email protected]> * Update apis Signed-off-by: obaydullahmhs <[email protected]> --------- Signed-off-by: obaydullahmhs <[email protected]>
kubedb · Jan 17, 2025 · a790052 · a790052
1 parent bdae9dd
commit a790052
Show file tree

Hide file tree

Showing 5 changed files with 96 additions and 1 deletion.
diff --git a/apis/kafka/v1alpha1/openapi_generated.go b/apis/kafka/v1alpha1/openapi_generated.go
diff --git a/apis/kafka/v1alpha1/restproxy_types.go b/apis/kafka/v1alpha1/restproxy_types.go
@@ -70,6 +70,11 @@ type RestProxySpec struct {
 	// +optional
 	PodTemplate ofst.PodTemplateSpec `json:"podTemplate,omitempty"`
 
+	// SchemaRegistryRef provides a reference to the Schema Registry configuration.
+	// the REST Proxy will connect to the Schema Registry if SchemaRegistryRef is provided.
+	// +optional
+	SchemaRegistryRef *SchemaRegistryRef `json:"schemaRegistryRef,omitempty"`
+
 	// ServiceTemplates is an optional configuration for services used to expose database
 	// +optional
 	ServiceTemplates []dbapi.NamedServiceTemplateSpec `json:"serviceTemplates,omitempty"`
@@ -84,6 +89,19 @@ type RestProxySpec struct {
 	HealthChecker kmapi.HealthCheckSpec `json:"healthChecker"`
 }
 
+// SchemaRegistryRef provides a reference to the Schema Registry configuration.
+type SchemaRegistryRef struct {
+	// Name and namespace of appbinding of schema registry
+	// If this is provided, the REST Proxy will connect to the Schema Registry
+	// InternallyManaged must be set to false in this case
+	// +optional
+	*kmapi.ObjectReference `json:",omitempty"`
+
+	// InternallyManaged true specifies if the schema registry runs internally along with the rest proxy
+	// +optional
+	InternallyManaged bool `json:"internallyManaged,omitempty"`
+}
+
 // RestProxyStatus defines the observed state of RestProxy
 type RestProxyStatus struct {
 	// Specifies the current phase of the database

diff --git a/apis/kafka/v1alpha1/restproxy_webhook.go b/apis/kafka/v1alpha1/restproxy_webhook.go
@@ -96,6 +96,19 @@ func (k *RestProxy) ValidateCreateOrUpdate() field.ErrorList {
 		return allErr
 	}
 
+	if k.Spec.SchemaRegistryRef != nil {
+		if k.Spec.SchemaRegistryRef.InternallyManaged && k.Spec.SchemaRegistryRef.ObjectReference != nil {
+			allErr = append(allErr, field.Invalid(field.NewPath("spec").Child("schemaRegistryRef").Child("objectReference"),
+				k.Name,
+				"ObjectReference should be nil when InternallyManaged is true"))
+		}
+		if !k.Spec.SchemaRegistryRef.InternallyManaged && k.Spec.SchemaRegistryRef.ObjectReference == nil {
+			allErr = append(allErr, field.Invalid(field.NewPath("spec").Child("schemaRegistryRef").Child("objectReference"),
+				k.Name,
+				"ObjectReference should not be nil when InternallyManaged is false"))
+		}
+	}
+
 	if k.Spec.DeletionPolicy == dbapi.DeletionPolicyHalt {
 		allErr = append(allErr, field.Invalid(field.NewPath("spec").Child("deletionPolicy"),
 			k.Name,

diff --git a/apis/kafka/v1alpha1/zz_generated.deepcopy.go b/apis/kafka/v1alpha1/zz_generated.deepcopy.go
diff --git a/crds/kafka.kubedb.com_restproxies.yaml b/crds/kafka.kubedb.com_restproxies.yaml
@@ -3152,6 +3152,17 @@ spec:
               replicas:
                 format: int32
                 type: integer
+              schemaRegistryRef:
+                properties:
+                  internallyManaged:
+                    type: boolean
+                  name:
+                    type: string
+                  namespace:
+                    type: string
+                required:
+                - name
+                type: object
               serviceTemplates:
                 items:
                   properties: