refactor

Signed-off-by: SK Ali Arman <[email protected]>

apis/catalog/v1alpha1/mariadb_version_helpers.go

@@ -56,12 +56,14 @@ func (m MariaDBVersion) ValidateSpecs() error {
 	if m.Spec.Version == "" ||
 		m.Spec.DB.Image == "" ||
 		m.Spec.Exporter.Image == "" ||
+		m.Spec.Maxscale.Image == "" ||
 		m.Spec.InitContainer.Image == "" ||
 		m.Spec.Coordinator.Image == "" {
 		return fmt.Errorf(`atleast one of the following specs is not set for mariadbversion "%v":
 spec.version,
 spec.db.image,
 spec.exporter.image,
+spec.maxscale.image,
 spec.initContainer.image,
 spec.coordinator.image.`, m.Name)
 	}

apis/kubedb/constants.go

@@ -358,10 +358,15 @@ const (
 	MariaDBMetricsExporterTLSVolumeName  = "metrics-exporter-config"
 	MariaDBMetricsExporterConfigPath     = "/etc/mysql/config/exporter"
 	MariaDBDataVolumeName                = "data"
+	DatabasePodPrimaryComponent          = "Primary"
+	DatabasePodMasterComponent           = "Master"
+	DatabasePodSlaveComponent            = "Slave"
 
 	// Maxscale
+	MaxscaleCommonName        = "maxscale"
 	MaxscaleContainerName     = "maxscale"
 	MaxscaleInitContainerName = "maxscale-init"
+	MaxscaleServerName        = "server"
 
 	// =========================== SingleStore Constants ============================
 	SinglestoreDatabasePortName       = "db"

apis/kubedb/v1/mariadb_helpers.go

@@ -59,7 +59,7 @@ func (m MariaDB) OffshootName() string {
 }
 
 func (m MariaDB) OffshootMaxscaleName() string {
-	return meta_util.NameWithSuffix(m.Name, "maxscale")
+	return meta_util.NameWithSuffix(m.Name, kubedb.MaxscaleCommonName)
 }
 
 func (m MariaDB) OffshootSelectors() map[string]string {