Add back podSecurityPolicy.enabled checks #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AjayTripathy PTAL thank you 🙏 |
AjayTripathy
approved these changes
Feb 8, 2021
|
(The default value is intended to be true-- we got feedback from users that they want to make sure this is always deployed) |
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was removed in #733. With the removal of the checks, the PSP is now always deployed where in the past it was defaulted to false. This has broken our build after upgrading to 1.73.0; in cases where two instances of kubecost are deployed on a cluster, there is a collision of the PSP name - perhaps a fix can be to generate unique names using
{{ template "cost-analyzer.fullname" . }}, happy to add that in this pr or another if that makes sense.I've added the checks back in to use the value, I'm not sure if this was intentionally removed or not. Let me know if the value should be defaulted to
trueaccompanying this change if the intention was to always deploy it.