Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove-old-api-port #3781

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Remove-old-api-port #3781

merged 2 commits into from
Dec 17, 2024

Conversation

jessegoodier
Copy link
Collaborator

@jessegoodier jessegoodier commented Dec 17, 2024

What does this PR change?

Removes reference to old /api nginx config pointing to port 9001 that was removed in 2.0

Does this PR rely on any other PRs?

NO

How does this PR impact users? (This is the kind of thing that goes in release notes!)

Removes reference to old /api nginx config pointing to port 9001 that was removed in 2.0

Links to Issues or tickets this PR addresses or fixes

#3727

What risks are associated with merging this PR? What is required to fully test this PR?

No risk from what I can find. Also confirmed with Bianca

How was this PR tested?

QA test on both sts and single pod aggregator.

Have you made an update to documentation? If so, please provide the corresponding PR.

NA

@jessegoodier
Copy link
Collaborator Author

@biancaburtoiu I believe when we removed federator, we removed 9001 /api
I do not see any calls to it in the UI. Any place else you can think of to check?

@jessegoodier jessegoodier marked this pull request as ready for review December 17, 2024 14:28
@jessegoodier jessegoodier added v2.6 bug Something isn't working labels Dec 17, 2024
@jessegoodier jessegoodier requested a review from ameijer December 17, 2024 14:29
@jessegoodier
Copy link
Collaborator Author

We discussed as a team, we all believe it was just overlooked in the 2.0 migration.

Copy link
Contributor

@ameijer ameijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think this was downright misleading. still concerned though that it only dies sometimes with invalid upstreams as in #3727

Copy link
Collaborator

@biancaburtoiu biancaburtoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessegoodier jessegoodier merged commit 0a2fa2f into develop Dec 17, 2024
37 checks passed
@jessegoodier jessegoodier deleted the remove-old-api-port branch December 17, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants