Adding OpenShift SCC clusterController, removing hostPort #3677
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| {{- if and (.Capabilities.APIVersions.Has "security.openshift.io/v1/SecurityContextConstraints") (.Values.global.platforms.openshift.scc.clusterController) (.Values.clusterController.enabled) }} | ||
| apiVersion: security.openshift.io/v1 | ||
| kind: SecurityContextConstraints | ||
| metadata: | ||
| name: {{ template "kubecost.clusterControllerName" . }} | ||
| priority: 10 | ||
| allowPrivilegedContainer: true | ||
| allowHostDirVolumePlugin: true | ||
| allowHostNetwork: true | ||
| allowHostPorts: true | ||
|
There was a problem hiding this comment. So this would now be |
||
| allowHostPID: false | ||
| allowHostIPC: false | ||
| readOnlyRootFilesystem: false | ||
| runAsUser: | ||
| type: RunAsAny | ||
| fsGroup: | ||
| type: RunAsAny | ||
| seLinuxContext: | ||
| type: RunAsAny | ||
| supplementalGroups: | ||
| type: RunAsAny | ||
| seccompProfiles: | ||
| - runtime/default | ||
| volumes: | ||
| - hostPath | ||
| - projected | ||
| - configMap | ||
| hostPorts: | ||
|
There was a problem hiding this comment. You can kill these hostPort lines if Alex is good with removing hostPort. |
||
| - min: 9731 | ||
| max: 9731 | ||
| users: | ||
| - system:serviceaccount:{{ .Release.Namespace }}:{{ template "kubecost.clusterControllerName" . }} | ||
| {{- end }} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -256,7 +256,6 @@ spec: | |
| ports: | ||
| - name: http-server | ||
| containerPort: 9731 | ||
|
There was a problem hiding this comment. @alexkubecost I can dig here, but do you know off hand why we would need hostPort? I don't understand why anything would be connecting to the clusterController that doesn't know the service name. There was a problem hiding this comment. I can't currently think of any reason why hostPort would be needed. @ameijer ? There was a problem hiding this comment. I'll bet you that this yaml was written from an example where they exposed an http port on a node and the ingress controller routed to that. I agree there is rarely if ever a use case for a host port on non daemon set controllers. I think getting rid of it is a great idea |
||
| serviceAccount: {{ template "kubecost.clusterControllerName" . }} | ||
| serviceAccountName: {{ template "kubecost.clusterControllerName" . }} | ||
| {{- with .Values.clusterController.tolerations }} | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -247,6 +247,7 @@ global: | |||||
| scc: | ||||||
| nodeExporter: false # Creates an SCC for Prometheus Node Exporter. This requires Node Exporter be enabled. | ||||||
| networkCosts: false # Creates an SCC for Kubecost network-costs. This requires network-costs be enabled. | ||||||
| clusterController: false # Creates an SCC for Kubecost clusterContoller. This requires clusterController be enabled. | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| # When OpenShift is enabled, the following securityContext will be applied to all resources unless they define their own. | ||||||
| securityContext: | ||||||
| runAsNonRoot: true | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to change this now it's targeting
develop.