Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bitnami/configmap-reload from 0.7.1 to 0.11.1 in /cost-analyzer #2555

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 28, 2023

Bumps bitnami/configmap-reload from 0.7.1 to 0.11.1.

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps bitnami/configmap-reload from 0.7.1 to 0.11.1.

---
updated-dependencies:
- dependency-name: bitnami/configmap-reload
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@thomasvn
Copy link
Member

What risks are associated with merging this PR? What is required to fully test this PR?
Low risk. This container only performs configmap reloading. Additionally only values-eks-cost-monitoring.yaml uses this image.

How was this PR tested?
Not tested. Please let me know if you think we should.

@thomasvn thomasvn requested a review from chipzoller August 29, 2023 23:31
@chipzoller
Copy link
Collaborator

chipzoller commented Aug 29, 2023

What is the impact if this bump results in an inoperable situation with the EKS values?

@thomasvn
Copy link
Member

@chipzoller Could you clarify? Inoperable meaning the configmap reloader fails to function as intended?

@chipzoller
Copy link
Collaborator

Inoperable meaning the configmap reloader fails to function as intended?

Yes, what happens if this totally doesn't work? What operations/scenarios will see this impact? I ask because, given semver 2.0 which is what this app conforms to, bumping patches is considered "safe" but this is a bump of a minor version and that assumption cannot usually be made there. The best thing to do in this case is test this, at the very least the most basic function it performs and I don't know what that is given my present experience.

@thomasvn thomasvn requested a review from jessegoodier August 30, 2023 18:38
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 2, 2023

Superseded by #2617.

@dependabot dependabot bot closed this Oct 2, 2023
@dependabot dependabot bot deleted the dependabot/docker/cost-analyzer/bitnami/configmap-reload-0.11.1 branch October 2, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants