Missing labels on kubecostChecks

[pierluigilenoci]

Describe the bug
The pods of the kubecostCheck cronjob don't have unique labels that allow them to be identified.
It is therefore difficult to create NetworkPolicy with the pods.

Ref: #743

To Reproduce
Deploy the package with NP enabled with a policy like this:

---
kind: NetworkPolicy
apiVersion: networking.k8s.io/v1
metadata:
  name: deny-all-ingress-traffic
  namespace: <yournamespace>
spec:
  podSelector: {}
  policyTypes:
    - Ingress

Try to create a Network Policy to allow kubecostCheck to reach other Kubecost pods.

Example:

---
kind: NetworkPolicy
apiVersion: networking.k8s.io/v1
metadata:
  name: allow-kubecostcheck-to-cost-analyzer
  namespace: <yournamespace>
spec:
  podSelector:
    matchLabels:
      app.kubernetes.io/name: cost-analyzer
  ingress:
    - from:
        - podSelector:
            matchLabels:
              app.kubernetes.io/name: kubecostcheck # or any other label you like more
        - namespaceSelector:
            matchLabels:
              name: <yournamespace>
  policyTypes:
    - Ingress

Expected behavior
The pod is launched with proper labels.

Example:

  labels:
    app: cost-analyzer
    app.kubernetes.io/instance: cost-analyzer
    app.kubernetes.io/name: kubecostcheck # or any other label you like more

[pierluigilenoci]

If it's not too much to ask, it would be really valuable to be able to define arbitrary labels and annotations to all possible pods that should be launched.

[dwbrown2]

This seems like a straightforward addition. Any blockers that you see @AjayTripathy?

[AjayTripathy]

No, we can add this.

[AjayTripathy]

Went ahead and did #777 @pierluigilenoci to support additional labels on all pods created by kubecost-- the subcharts should already support these options. Let us know what you think!

[pierluigilenoci]

@AjayTripathy I am very pleased that you have provided the possibility to add custom labels and annotations. But I think following the recommendations [1] is still a good thing.

[1] https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

[pierluigilenoci]

@AjayTripathy what do you think about this? #761 (comment)

@AjayTripathy I am very pleased that you have provided the possibility to add custom labels and annotations. But I think following the recommendations [1] is still a good thing.

[pierluigilenoci]

@AjayTripathy this is still not working because commonLabels and additionalLabels are in the wrong manifest level. To make the pod inherit them, they must be put at this level: spec.jobTemplate.spec.template.metadata.labels

[pierluigilenoci]

@dwbrown2 @AjayTripathy any news on this topic?

[AjayTripathy]

Should be done in #827

[AjayTripathy]

Actually, checks pod will get deprecated in 1.79.0, so we may just close this.

[dwbrown2]

Note this functionality will be moved into the core kubecost pod.