Tolerations missing from job cost-analyzer-checks

[ghost]

Describe the bug
With the last release, you added the support of nodeselectors through all resources. But you did not add tolerations to the job cost-analyzer-checks as well, which results in provisioning errors/problems.

Expected behavior
Please add this settings for the job as well or remove the nodeselectors for the job. Also currently there are general options for nodeselector and tolerations, but also a networkcosts specific option for tolerations. Please use the general options for all resources. There is no need to have different tolerations here.

In "cost-analyzer-checks-template.yaml", you can see that only nodeSelector is used and not tolerations.

cost-analyzer-helm-chart/cost-analyzer/templates/cost-analyzer-checks-template.yaml

Line 62 in 7a43a04

nodeSelector:

[pierluigilenoci]

Hi @li-adrienloiseau the version 1.73.0 should have this setting.
https://github.com/kubecost/cost-analyzer-helm-chart/blob/develop/cost-analyzer/values.yaml#L226

[ghost]

The version 1.73.0 only has the setting for nodeSelector, not tolerations, for the cost-analyzer-checks jobs. The tolerations setting is not put through.
https://github.com/kubecost/cost-analyzer-helm-chart/blob/develop/cost-analyzer/templates/cost-analyzer-checks-template.yaml

[pierluigilenoci]

Ok, now I understand.
Missing here: https://github.com/kubecost/cost-analyzer-helm-chart/blob/develop/cost-analyzer/templates/cost-analyzer-checks-template.yaml#L62-L64

[dwbrown2]

#780 is now outstanding! That look good @Zenmodai @pierluigilenoci?

[pierluigilenoci]

@dwbrown2 almost good. It is better do define separate tolerations/nodeselector for any element of the software. Ref: #772

[michaelmdresser]

Closing this issue because it seems to be addressed. We'll leave #772 open.