Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass tolerations through to cost analyzer checks #780

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

michaelmdresser
Copy link
Contributor

Addresses #758

Testing

Set the following in cost-analyzer/values.yaml:

tolerations:
  - key: "testtaint"
    operator: "Equal"
    value: "testvalue"
    effect: "NoSchedule"

Ran one deployment before the change, ran one deployment after the change.

Before the change, a checks pod had the following (from kubectl describe:

Tolerations:     node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                 node.kubernetes.io/unreachable:NoExecute op=Exists for 300s

After the change, a checks pod had the following:

Tolerations:     node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                 node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
                 testtaint=testvalue:NoSchedule

@michaelmdresser michaelmdresser merged commit c716fd9 into develop Feb 19, 2021
@michaelmdresser michaelmdresser deleted the mmd-tolerations-on-checks branch February 19, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants