Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI_tests): upgrade ginkgo pkg before running test in CI. #963

Closed
wants to merge 1 commit into from

Conversation

rksharma95
Copy link
Collaborator

@rksharma95 rksharma95 commented Nov 3, 2022

Purpose of PR?:
currently when running ginkgo tests in github CI test , the installed(latest) ginkgo CLI tool may have conflict with the ginkgo pkg version used by the tests resulting in CI test failure, as we are not upgrading the pkg before running tests.

Ginkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages:
  Ginkgo CLI Version:
    2.4.0
  Mismatched package versions found:
    2.1.4 used by multicontainer, smoke, syscalls

this PR changes the Makefile to upgrade the pkg before running tests.

Fixes #

Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

Signed-off-by: rksharma95 [email protected]

Signed-off-by: rksharma95 <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Merging #963 (7f1dc87) into main (7fdfe6d) will decrease coverage by 1.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #963      +/-   ##
==========================================
- Coverage   39.35%   37.45%   -1.90%     
==========================================
  Files          31       31              
  Lines        9843     9843              
==========================================
- Hits         3874     3687     -187     
- Misses       5461     5662     +201     
+ Partials      508      494      -14     
Impacted Files Coverage Δ
KubeArmor/core/crioHandler.go 0.00% <0.00%> (-60.52%) ⬇️
KubeArmor/core/containerdHandler.go 53.18% <0.00%> (-15.74%) ⬇️
KubeArmor/core/kubeArmor.go 48.23% <0.00%> (-1.77%) ⬇️
KubeArmor/core/kubeUpdate.go 38.19% <0.00%> (-0.23%) ⬇️
KubeArmor/core/dockerHandler.go 47.47% <0.00%> (+2.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rksharma95 rksharma95 changed the title fix(tests): upgrade ginkgo pkg before running test in CI. chore(CI_tests): upgrade ginkgo pkg before running test in CI. Nov 4, 2022
@DelusionalOptimist
Copy link
Member

@rksharma95 do we still need this after #1126?

@rksharma95
Copy link
Collaborator Author

@rksharma95 do we still need this after #1126?

nope, we can close this PR, thanks @DelusionalOptimist.

@DelusionalOptimist
Copy link
Member

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants