-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add FAQs #786
Merged
Merged
add FAQs #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ankurk99
force-pushed
the
FAQ
branch
2 times, most recently
from
July 30, 2022 09:27
697ffe5
to
3aaa962
Compare
nyrahul
reviewed
Jul 31, 2022
Ankurk99
force-pushed
the
FAQ
branch
3 times, most recently
from
August 4, 2022 06:49
1ce3990
to
127c488
Compare
Ankurk99
requested review from
0verflowme,
achrefbensaad,
daemon1024,
seswarrajan and
nyrahul
and removed request for
0verflowme
August 4, 2022 06:53
seswarrajan
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
achrefbensaad
approved these changes
Aug 9, 2022
nyrahul
requested changes
Aug 9, 2022
Signed-off-by: Ankur Kothiwal <[email protected]>
Thank you @nyrahul for the in-depth review |
nyrahul
approved these changes
Aug 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #647