Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FAQs #786

Merged
merged 1 commit into from
Aug 28, 2022
Merged

add FAQs #786

merged 1 commit into from
Aug 28, 2022

Conversation

Ankurk99
Copy link
Member

ref #647

@Ankurk99 Ankurk99 force-pushed the FAQ branch 2 times, most recently from 697ffe5 to 3aaa962 Compare July 30, 2022 09:27
getting-started/FAQ.md Outdated Show resolved Hide resolved
getting-started/FAQ.md Outdated Show resolved Hide resolved
@Ankurk99 Ankurk99 force-pushed the FAQ branch 3 times, most recently from 1ce3990 to 127c488 Compare August 4, 2022 06:49
@Ankurk99 Ankurk99 marked this pull request as ready for review August 4, 2022 06:52
@Ankurk99 Ankurk99 requested review from 0verflowme, achrefbensaad, daemon1024, seswarrajan and nyrahul and removed request for 0verflowme August 4, 2022 06:53
Copy link
Contributor

@seswarrajan seswarrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

getting-started/FAQ.md Outdated Show resolved Hide resolved
getting-started/FAQ.md Outdated Show resolved Hide resolved
getting-started/FAQ.md Outdated Show resolved Hide resolved
getting-started/FAQ.md Show resolved Hide resolved
getting-started/FAQ.md Outdated Show resolved Hide resolved
getting-started/FAQ.md Outdated Show resolved Hide resolved
getting-started/FAQ.md Outdated Show resolved Hide resolved
getting-started/FAQ.md Outdated Show resolved Hide resolved
Signed-off-by: Ankur Kothiwal <[email protected]>
@Ankurk99
Copy link
Member Author

Ankurk99 commented Aug 9, 2022

Thank you @nyrahul for the in-depth review

@nyrahul nyrahul added this to the v0.6 milestone Aug 28, 2022
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@nyrahul nyrahul merged commit 8b6634e into kubearmor:main Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants