Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code CleanUp #751

Merged
merged 4 commits into from
Jul 4, 2022
Merged

Code CleanUp #751

merged 4 commits into from
Jul 4, 2022

Conversation

nam-jaehyun
Copy link
Collaborator

  • update GitHub action
  • update setup scripts
  • clean up the code of KubeArmor

Signed-off-by: Jaehyun Nam <[email protected]>
Signed-off-by: Jaehyun Nam <[email protected]>
Signed-off-by: Jaehyun Nam <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2022

Codecov Report

Merging #751 (27bb664) into main (e1d6818) will decrease coverage by 0.01%.
The diff coverage is 70.96%.

@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
- Coverage   41.27%   41.26%   -0.02%     
==========================================
  Files          25       25              
  Lines        8996     8994       -2     
==========================================
- Hits         3713     3711       -2     
  Misses       4802     4802              
  Partials      481      481              
Impacted Files Coverage Δ
KubeArmor/common/common.go 41.66% <ø> (ø)
KubeArmor/core/kubeArmor.go 52.87% <60.00%> (ø)
KubeArmor/config/config.go 86.82% <66.66%> (-0.30%) ⬇️
KubeArmor/core/containerdHandler.go 57.08% <100.00%> (ø)
KubeArmor/core/crioHandler.go 63.86% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 992a6ab...27bb664. Read the comment docs.

Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@DelusionalOptimist DelusionalOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nam-jaehyun.

Signed-off-by: Jaehyun Nam <[email protected]>
@nam-jaehyun nam-jaehyun merged commit 8e74a24 into kubearmor:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants