Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix k3s installation script to use proper kubectl command #743

Merged
merged 1 commit into from
Jul 7, 2022
Merged

fix k3s installation script to use proper kubectl command #743

merged 1 commit into from
Jul 7, 2022

Conversation

Ankurk99
Copy link
Member

No description provided.

@Ankurk99 Ankurk99 requested a review from nyrahul June 24, 2022 16:03
@nam-jaehyun
Copy link
Collaborator

@Ankurk99 I used the absolute path because kubectl is not in $PATH during 'make vagrant-up OS=centos'. Can you check the centos-based vagrant env?

@Ankurk99
Copy link
Member Author

Ankurk99 commented Jul 4, 2022

@Ankurk99 I used the absolute path because kubectl is not in $PATH during 'make vagrant-up OS=centos'. Can you check the centos-based vagrant env?

I see. But some distro installs kubectl at /usr/bin/kubectl, wouldn't that be an issue?

@nyrahul nyrahul merged commit b7a0176 into kubearmor:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyrahul nyrahul nyrahul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ankurk99 @nam-jaehyun @nyrahul