Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up KubeArmorAnnotation #738

Merged
merged 9 commits into from
Jun 20, 2022
Merged

clean up KubeArmorAnnotation #738

merged 9 commits into from
Jun 20, 2022

Conversation

nam-jaehyun
Copy link
Collaborator

  • clean up KubeArmorAnnotation
  • update GitHub Action

Signed-off-by: Jaehyun Nam <[email protected]>
Signed-off-by: Jaehyun Nam <[email protected]>
Signed-off-by: Jaehyun Nam <[email protected]>
Signed-off-by: Jaehyun Nam <[email protected]>
Signed-off-by: Jaehyun Nam <[email protected]>
Signed-off-by: Jaehyun Nam <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2022

Codecov Report

Merging #738 (c9b60c8) into main (cd78955) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
+ Coverage   39.31%   39.33%   +0.02%     
==========================================
  Files          24       24              
  Lines        8702     8702              
==========================================
+ Hits         3421     3423       +2     
+ Misses       4828     4826       -2     
  Partials      453      453              
Impacted Files Coverage Δ
KubeArmor/core/kubeArmor.go 54.42% <0.00%> (ø)
KubeArmor/monitor/systemMonitor.go 51.16% <0.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd78955...c9b60c8. Read the comment docs.

@nam-jaehyun nam-jaehyun requested a review from nyrahul June 14, 2022 09:47
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nyrahul
Copy link
Contributor

nyrahul commented Jun 17, 2022

@achrefbensaad , can you please review this code? (Not able to add you as reviewer!)

@achrefbensaad
Copy link
Member

LGTM!
@nam-jaehyun I opened an PR dku-boanlab#1 to be merged before this gets to main, as while I was testing I noticied that pod_mutation.go does not honor the fallback logic as it uses Fail rather than Ignore (my bad).
I also regenerated the deployments yaml.

@achrefbensaad
Copy link
Member

@nyrahul I cant be added as a reviewer as I do not have write access to the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants