-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update github.com/containerd/containerd to v1.5.13 to fix security issues #726
Update github.com/containerd/containerd to v1.5.13 to fix security issues #726
Conversation
ddc2e76
to
9d4cc53
Compare
9d4cc53
to
2cfdf44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @bmelbourne
I am getting a different go.sum
when I run go mod tidy
with the new go.mod
. This is been verified. We are also trying to add a CI check to cross-verify the generated go.sum
.
2cfdf44
to
16d2079
Compare
@nyrahul |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please find comments inline. Thanks again for the PR.
KubeArmor/go.mod
Outdated
@@ -19,7 +19,8 @@ replace ( | |||
) | |||
|
|||
require ( | |||
github.com/containerd/containerd v1.5.2 | |||
github.com/Microsoft/go-winio v0.5.2 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to explicitly state this indirect dependency? Similarly, there are few other indirect dependencies down this file which are newly added and the compilation works fine even if removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An indirect dependency on MS winio! I am not sure if this is needed. Please check. Thanks
KubeArmor/go.sum
Outdated
github.com/containerd/ttrpc v1.0.2/go.mod h1:UAxOpgT9ziI0gJrmKvgcZivgxOp8iFPSk8httJEt98Y= | ||
github.com/containerd/ttrpc v1.1.0 h1:GbtyLRxb0gOLR0TYQWt3O6B0NvT8tMdorEHqIQo/lWI= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run go mod tidy
it does not generate this line. When I checked the details, this line is supposed to get the checksum of entire code base of ttrpc whereas the next line containing ....ttrpc/go.mod
simply gets a checksum on the go.mod
file.
Point is, do we require this explicit entire code base checksum to be added?
Also I dont understand why it does not get added when I run go mod tidy
. Is there any specific flag you used with the tidy command?
16d2079
to
e195eb2
Compare
/reopen |
Update Go github.com/containerd/containerd package to v1.5.13 to fix critical security vulnerabilities outlined in CVE-2021-43816 and CVE-2022-31030.
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-43816
GHSA-5ffw-gxpp-mxpf (CVE-2022-31030)