Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add annotation controller docs #686

Merged

Conversation

achrefbensaad
Copy link
Member

Signed-off-by: Achref Ben Saadd [email protected]

@achrefbensaad achrefbensaad force-pushed the add-controller-documentations branch from 44532be to 3dc8919 Compare May 15, 2022 20:14
@achrefbensaad achrefbensaad mentioned this pull request May 15, 2022
@nyrahul nyrahul added this to the v0.5 milestone Jun 13, 2022
@nyrahul
Copy link
Contributor

nyrahul commented Jul 4, 2022

Hey @achrefbensaad , is this still in draft phase? We can assume v0.5 as the release which will have annotation controller. Can we update the docs to reflect that and change it to normal PR?

Signed-off-by: Achref Ben Saadd <[email protected]>
@achrefbensaad achrefbensaad force-pushed the add-controller-documentations branch from 3dc8919 to 6d85e92 Compare July 4, 2022 09:09
@achrefbensaad achrefbensaad marked this pull request as ready for review July 4, 2022 09:10
@achrefbensaad
Copy link
Member Author

@nyrahul Done.

@nyrahul nyrahul self-requested a review July 4, 2022 09:11
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@nyrahul nyrahul merged commit c714aa6 into kubearmor:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants