Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update stable tag to point to the latest version release branch #628

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

Ankurk99
Copy link
Member

No description provided.

@Ankurk99 Ankurk99 requested a review from nyrahul February 17, 2022 12:17
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we discussed that these changes won't work. We have two scenarios where stable tag should be updated:

  1. when STABLE-RELEASE file is changed in main branch.
  2. when a push event happens in the v* branch which is also the branch name in STABLE-RELEASE file in main branch.

.github/workflows/stable-release.yml Outdated Show resolved Hide resolved
@Ankurk99 Ankurk99 force-pushed the branchstable branch 2 times, most recently from 1237c90 to aa08adb Compare February 17, 2022 15:59
@Ankurk99 Ankurk99 marked this pull request as draft February 17, 2022 16:03
@Ankurk99 Ankurk99 marked this pull request as ready for review February 17, 2022 16:29
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PFA my review. Thanks

.github/workflows/stable-version-release.yml Outdated Show resolved Hide resolved
.github/workflows/stable-version-release.yml Outdated Show resolved Hide resolved
.github/workflows/stable-version-release.yml Show resolved Hide resolved
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@nyrahul nyrahul merged commit 7b0baa4 into kubearmor:main Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants