-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update stable tag to point to the latest version release branch #628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we discussed that these changes won't work. We have two scenarios where stable tag should be updated:
- when
STABLE-RELEASE
file is changed inmain
branch. - when a push event happens in the v* branch which is also the branch name in
STABLE-RELEASE
file inmain
branch.
8197e7f
to
d7fb250
Compare
1237c90
to
aa08adb
Compare
aa08adb
to
53e899e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PFA my review. Thanks
Signed-off-by: Ankur Kothiwal <[email protected]>
53e899e
to
babf216
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
No description provided.