refactor(tests): replace K8sExecInPod with AssertCommand for consistency in test assertions #1890
Conversation
|
hey @daemon1024 @rootxrishabh please approve the workflows and review this. |
|
hey @rootxrishabh last time the checks failed because of some typo, i have fixed it and pushed the changes, please approve the workflows and let me know if you find anything else that needs to be fixed. |
|
hey @daemon1024 @rootxrishabh @PrimalPimmy if anyone of you can approve the workflow and review this, so that i get to know if everything is working fine with the changes. |
|
Can we debug the tests and make them passing? |
|
hey @daemon1024 i have fixed the errors occured in the tests, now they should succeed as expected. please approve the workflows. thanks. |
|
@abhashsolanki18 there are some other issues as well that we're facing in CI, we're working on it, once it's fixed i will revert back here. |
|
@abhashsolanki18 can you please rebase to main? |
abhashsolanki18
force-pushed
the
issue#1643
branch
from
e7fcc34 to
0d914b1
Compare
hey @rksharma95 i have rebased to main, thanks. |
|
@abhashsolanki18 can you squash the commits as well? |
abhashsolanki18
force-pushed
the
issue#1643
branch
from
0d914b1 to
3781676
Compare
@rksharma95 Done. |
|
hey @rksharma95 is this PR getting merged or are there any issue with the fix? thanks. |
|
@abhashsolanki18 can you please handle the ci failure? We could merge after all tests are passing. |
abhashsolanki18
force-pushed
the
issue#1643
branch
2 times, most recently
from
6d15737 to
5cd51be
Compare
Signed-off-by: abhashsolanki18 <[email protected]>
abhashsolanki18
force-pushed
the
issue#1643
branch
from
5cd51be to
5fa1489
Compare
@rksharma95 please approve the tests, thanks. |
Purpose of PR?:
Fixes #1643
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? : This PR is part of the refactoring effort to standardize test execution methods. It follows up on a previous PR where initial AssertCommand replacements were introduced.
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>