Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tests): replace K8sExecInPod with AssertCommand for consistency in test assertions #1890

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abhashsolanki18
Copy link

Purpose of PR?:

Fixes #1643

Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::

  1. Verified that the K8sExecInPod calls were successfully replaced with AssertCommand without impacting test results.
  2. Confirmed that permissions and expected outputs are consistent with the new implementation.
  3. Ensured that refactored code retains functionality across all test cases.

Additional information for reviewer? : This PR is part of the refactoring effort to standardize test execution methods. It follows up on a previous PR where initial AssertCommand replacements were introduced.
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes CI(tests) Use AssertCommand function in every test #1643
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@abhashsolanki18
Copy link
Author

abhashsolanki18 commented Nov 10, 2024

hey @daemon1024 @rootxrishabh please approve the workflows and review this.

@abhashsolanki18
Copy link
Author

hey @rootxrishabh last time the checks failed because of some typo, i have fixed it and pushed the changes, please approve the workflows and let me know if you find anything else that needs to be fixed.

@abhashsolanki18
Copy link
Author

abhashsolanki18 commented Nov 12, 2024

hey @daemon1024 @rootxrishabh @PrimalPimmy if anyone of you can approve the workflow and review this, so that i get to know if everything is working fine with the changes.

@daemon1024
Copy link
Member

Can we debug the tests and make them passing?

@abhashsolanki18
Copy link
Author

hey @daemon1024 i have fixed the errors occured in the tests, now they should succeed as expected. please approve the workflows. thanks.

@rksharma95
Copy link
Collaborator

@abhashsolanki18 there are some other issues as well that we're facing in CI, we're working on it, once it's fixed i will revert back here.

@rksharma95
Copy link
Collaborator

@abhashsolanki18 can you please rebase to main?

@abhashsolanki18
Copy link
Author

@abhashsolanki18 can you please rebase to main?

hey @rksharma95 i have rebased to main, thanks.

@rksharma95
Copy link
Collaborator

@abhashsolanki18 can you squash the commits as well?

@abhashsolanki18
Copy link
Author

@abhashsolanki18 can you squash the commits as well?

@rksharma95 Done.

@abhashsolanki18
Copy link
Author

hey @rksharma95 is this PR getting merged or are there any issue with the fix? thanks.

@rksharma95
Copy link
Collaborator

@abhashsolanki18 can you please handle the ci failure? We could merge after all tests are passing.

@abhashsolanki18 abhashsolanki18 force-pushed the issue#1643 branch 2 times, most recently from 6d15737 to 5cd51be Compare December 17, 2024 09:00
@abhashsolanki18
Copy link
Author

@abhashsolanki18 can you please handle the ci failure? We could merge after all tests are passing.

@rksharma95 please approve the tests, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI(tests) Use AssertCommand function in every test
3 participants