fix(policymatcher): skip future matching in case block/audit matches #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aryan-sharma11
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
why are we not skipping when matched for allow case?
any specific reason?
Aryan-sharma11
force-pushed
the
fix-dp-policymatch
branch
from
0b3c87f to
523b185
Compare
Prateeknandle
approved these changes
Sep 2, 2024
daemon1024
force-pushed
the
fix-dp-policymatch
branch
from
523b185 to
8aaabb2
Compare
Signed-off-by: daemon1024 <[email protected]>
Aryan-sharma11
force-pushed
the
fix-dp-policymatch
branch
from
8aaabb2 to
d572138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #1692
Does this PR introduce a breaking change?
NA
If the changes in this PR are manually verified, list down the scenarios covered::
Tested against policy mentioned in bug report
Checklist:
<type>(<scope>): <subject>