Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Migrate from manifests to helm in CI tests #1273

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

DelusionalOptimist
Copy link
Member

@DelusionalOptimist DelusionalOptimist commented Jun 21, 2023

Purpose of PR?:

Possibly fixes #1269

Does this PR introduce a breaking change?
No

If the changes in this PR are manually verified, list down the scenarios covered::
make -C tests/

Additional information for reviewer? :
Based on the analysis done in #1269, audited syscall events generally get dropped only after we have received a large number of events. It is strange as other events still seem to come by. Since reproducing this takes time and we want to have a stable CI in the upcoming release, this is a proposed quickfix which attempts to fix failures by:

  • Running syscalls suite first
  • Deleting deployments created by test suite once it completes
  • Migrating test manifests to helm chart

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@DelusionalOptimist DelusionalOptimist force-pushed the flakey-test-quickfix branch 4 times, most recently from b1f05f7 to 10be32c Compare June 23, 2023 11:11
- move CI installation method to helm
- cleanup deployments after each suite
- increase ginkgo verbosity to find out why each test flakes
- move some syscall test to syscalls suite from ksp

Signed-off-by: Rudraksh Pareek <[email protected]>
@DelusionalOptimist DelusionalOptimist changed the title quickfix(tests): Fix flakey tests by changing order and cleaning up after suite fix(tests): Migrate from manifests to helm in CI tests Jun 23, 2023
@DelusionalOptimist DelusionalOptimist marked this pull request as ready for review June 23, 2023 11:33
Signed-off-by: Rudraksh Pareek <[email protected]>
Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One query inline

.github/workflows/ci-test-controllers.yml Show resolved Hide resolved
@daemon1024 daemon1024 merged commit 4f5b8ac into kubearmor:main Jun 26, 2023
@DelusionalOptimist DelusionalOptimist deleted the flakey-test-quickfix branch July 3, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(syscalls): not receiving events for audited syscalls
2 participants