fix(monitor): set actual process name in logs instead of symlinks #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We resolved actual process names in and stored it in the userspace process map, but we never updated the log base created in kprobe event. This commit removes the null check and updates the log base with actual process names in the kretprobe event which we would have recieved from the bprm hook which was triggered before kretprobe execve(at) Signed-off-by: daemon1024 <[email protected]>
{"Timestamp":1685455502,"UpdatedTime":"2023-05-30T14:05:02.615298Z","NamespaceName":"container_namespace","PodName":"armored-container","ContainerID":"ce0e9a12750f6e26dc8e8481be8ef26035608d02bd2b27385ca47e6e11bdb651","ContainerName":"armored-container","ParentProcessName":"/bin/busybox","ProcessName":"/bin/busybox","HostPPID":59047,"HostPID":96816,"PPID":1,"PID":19,"Type":"ContainerLog","Source":"/bin/busybox","Operation":"Process","Resource":"/bin/cat file.txt","Data":"syscall=SYS_EXECVE","Result":"Passed"} |
achrefbensaad
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We resolved actual process names in and stored it in the userspace process map, but we never updated the log base created in kprobe event.
This PR removes the null check and updates the log base with actual process names in the kretprobe event which we would have recieved from the bprm hook which was triggered before kretprobe execve(at)
Purpose of PR?:
Fixes #984
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Check Telemetry Info using kArmor logs
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>