-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forced the protocol to lowercase in AppArmorProfile #1092
Conversation
Hey @achrefbensaad, I can't able to understand why 1 check got failed. |
Hi @kanhaiya04 , Thank you for your contribution. Failures can occur due to a flaykiness of the CI. |
e5b1f83
to
8a090bd
Compare
Hi @achrefbensaad, thanks for the guidance. I have made the changes accordingly, can you please review it. |
Hi @kanhaiya04 , Thank you for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌🏽 Appreciate the contribution
|
Hi @kanhaiya04 , Can you please rebase your code on top of main. Ill merge after a green pipeline. |
Hi @achrefbensaad, Done. |
No, after rebasing, please push to this PR. |
8a090bd
to
e45b0ea
Compare
Signed-off-by: kanhaiya04 <[email protected]>
Purpose of PR?:
Fixes #1019
Fixed the Network policy failure
Does this PR introduce a breaking change? No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? : Fixes #1019
Checklist:
<type>(<scope>): <subject>