Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forced the protocol to lowercase in AppArmorProfile #1092

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

kanhaiya04
Copy link
Contributor

Purpose of PR?:

Fixes #1019
Fixed the Network policy failure

Does this PR introduce a breaking change? No

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? : Fixes #1019

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@kanhaiya04
Copy link
Contributor Author

Hey @achrefbensaad, I can't able to understand why 1 check got failed.
Is it not the right way to fix this?

@achrefbensaad
Copy link
Member

Hi @kanhaiya04 , Thank you for your contribution.

Failures can occur due to a flaykiness of the CI.
On the other side, your current changes are CPU intensive. Please consider making the required changes in this block https://github.com/kubearmor/KubeArmor/blob/main/KubeArmor/enforcer/appArmorProfile.go#L223-L255

@kanhaiya04 kanhaiya04 changed the title forced the protocol to lowercase in GenerateAppArmorProfile forced the protocol to lowercase in AppArmorProfile Feb 6, 2023
@kanhaiya04
Copy link
Contributor Author

Hi @achrefbensaad, thanks for the guidance. I have made the changes accordingly, can you please review it.

@achrefbensaad
Copy link
Member

Hi @kanhaiya04 , Thank you for your contribution.

Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏽 Appreciate the contribution

@daemon1024
Copy link
Member

go-sec should pass after we merge #1098

@achrefbensaad
Copy link
Member

Hi @kanhaiya04 , Can you please rebase your code on top of main. Ill merge after a green pipeline.

@kanhaiya04
Copy link
Contributor Author

kanhaiya04 commented Feb 7, 2023

Hi @achrefbensaad, Done.
Do I have to create PR again from main branch?

@achrefbensaad
Copy link
Member

No, after rebasing, please push to this PR.

@kanhaiya04 kanhaiya04 reopened this Feb 7, 2023
@daemon1024 daemon1024 merged commit 006641f into kubearmor:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Network policies fails to apply (Apparmor)
3 participants