Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cloud provider apis #261

Merged
merged 5 commits into from
Oct 28, 2023
Merged

added cloud provider apis #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
55f5d7c
added cloud provider apis
sol-dev-abhi Oct 24, 2023
beb616a
validating mapping too
sol-dev-abhi Oct 24, 2023
35f8af8
resolved pr comments
sol-dev-abhi Oct 28, 2023
5335099
merged with main
sol-dev-abhi Oct 28, 2023
ddfa379
single api cloudtype and labels + removed empty update
sol-dev-abhi Oct 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions capten/agent/pkg/agent/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,23 @@ func (a *Agent) Ping(ctx context.Context, request *agentpb.PingRequest) (*agentp
return &agentpb.PingResponse{Status: agentpb.StatusCode_OK}, nil
}

func validateArgs(args ...string) error {
func validateArgs(args ...any) error {
for _, arg := range args {
if len(arg) == 0 {
return fmt.Errorf("mandatory argument is empty")
switch item := arg.(type) {
case string:
if len(item) == 0 {
return fmt.Errorf("empty string not allowed")
}
case map[string]string:
for k, v := range item {
if len(v) == 0 {
return fmt.Errorf("map value empty for key: %v", k)
}
}
default:
return fmt.Errorf("validation not implemented for this type")
}

}
return nil
}
226 changes: 208 additions & 18 deletions capten/agent/pkg/agent/plugin_cloud_provider_apis.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,45 +4,235 @@ import (
"context"
"fmt"

"github.com/google/uuid"
"github.com/intelops/go-common/credentials"
"github.com/kube-tarian/kad/capten/agent/pkg/pb/captenpluginspb"
)

const cloudProviderEntityName = "CloudProvider"

func (a *Agent) AddCloudProvider(ctx context.Context, request *captenpluginspb.AddCloudProviderRequest) (
*captenpluginspb.AddCloudProviderResponse, error) {
if err := validateArgs(request.GetCloudType(), request.GetCloudAttributes()); err != nil {
a.log.Infof("request validation failed", err)
return &captenpluginspb.AddCloudProviderResponse{
Status: captenpluginspb.StatusCode_INVALID_ARGUMENT,
StatusMessage: "request validation failed",
}, nil
}

a.log.Infof("Add Cloud Provider %s request received", request.CloudType)

id := uuid.New()
if err := a.storeCloudProviderCredential(ctx, id.String(), request.GetCloudAttributes()); err != nil {
return &captenpluginspb.AddCloudProviderResponse{
Status: captenpluginspb.StatusCode_INTERNAL_ERROR,
StatusMessage: "failed to add cloud provider credential in vault",
}, nil
}

CloudProvider := captenpluginspb.CloudProvider{
Id: id.String(),
CloudType: request.CloudType,
Labels: request.Labels,
}
if err := a.as.UpsertCloudProvider(&CloudProvider); err != nil {
a.log.Errorf("failed to store cloud provider to DB, %v", err)
return &captenpluginspb.AddCloudProviderResponse{
Status: captenpluginspb.StatusCode_INTERNAL_ERROR,
StatusMessage: "failed to add CloudProvider in db",
}, nil
}

a.log.Infof("Cloud Provider %s added with id %s", request.GetCloudType(), id.String())
return &captenpluginspb.AddCloudProviderResponse{
Status: captenpluginspb.StatusCode_NOT_FOUND,
StatusMessage: "not implemented",
}, fmt.Errorf("not implemented")
Id: id.String(),
Status: captenpluginspb.StatusCode_OK,
StatusMessage: "ok",
}, nil
}

func (a *Agent) UpdateCloudProviders(ctx context.Context, request *captenpluginspb.UpdateCloudProviderRequest) (
*captenpluginspb.UpdateCloudProviderResponse, error) {
if err := validateArgs(request.GetCloudType(), request.GetId(), request.GetCloudAttributes()); err != nil {
a.log.Infof("request validation failed", err)
return &captenpluginspb.UpdateCloudProviderResponse{
Status: captenpluginspb.StatusCode_INVALID_ARGUMENT,
StatusMessage: "request validation failed",
}, nil
}
a.log.Infof("Update Cloud Provider %s, %s request received", request.CloudType, request.Id)

id, err := uuid.Parse(request.Id)
if err != nil {
a.log.Infof("request validation failed", err)
return &captenpluginspb.UpdateCloudProviderResponse{
Status: captenpluginspb.StatusCode_INVALID_ARGUMENT,
StatusMessage: fmt.Sprintf("invalid uuid: %s", request.Id),
}, nil
}

if err := a.storeCloudProviderCredential(ctx, request.Id, request.GetCloudAttributes()); err != nil {
return &captenpluginspb.UpdateCloudProviderResponse{
Status: captenpluginspb.StatusCode_INTERNAL_ERROR,
StatusMessage: "failed to add CloudProvider credential in vault",
}, nil
}

CloudProvider := captenpluginspb.CloudProvider{
Id: id.String(),
CloudType: request.CloudType,
Labels: request.Labels,
}
if err := a.as.UpsertCloudProvider(&CloudProvider); err != nil {
a.log.Errorf("failed to update CloudProvider in db, %v", err)
return &captenpluginspb.UpdateCloudProviderResponse{
Status: captenpluginspb.StatusCode_INTERNAL_ERROR,
StatusMessage: "failed to update CloudProvider in db",
}, nil
}

a.log.Infof("Cloud Provider %s, %s updated", request.CloudType, request.Id)
return &captenpluginspb.UpdateCloudProviderResponse{
Status: captenpluginspb.StatusCode_NOT_FOUND,
StatusMessage: "not implemented",
}, fmt.Errorf("not implemented")
Status: captenpluginspb.StatusCode_OK,
StatusMessage: "ok",
}, nil
}

func (a *Agent) DeleteCloudProvider(ctx context.Context, request *captenpluginspb.DeleteCloudProviderRequest) (
*captenpluginspb.DeleteCloudProviderResponse, error) {
if err := validateArgs(request.GetId()); err != nil {
a.log.Infof("request validation failed", err)
return &captenpluginspb.DeleteCloudProviderResponse{
Status: captenpluginspb.StatusCode_INVALID_ARGUMENT,
StatusMessage: "request validation failed",
}, nil
}
a.log.Infof("Delete Cloud Provider %s request recieved", request.Id)

if err := a.as.DeleteCloudProviderById(request.Id); err != nil {
a.log.Errorf("failed to delete CloudProvider from db, %v", err)
return &captenpluginspb.DeleteCloudProviderResponse{
Status: captenpluginspb.StatusCode_INTERNAL_ERROR,
StatusMessage: "failed to delete CloudProvider from db",
}, nil
}

a.log.Infof("Cloud Provider %s deleted", request.Id)
return &captenpluginspb.DeleteCloudProviderResponse{
Status: captenpluginspb.StatusCode_NOT_FOUND,
StatusMessage: "not implemented",
}, fmt.Errorf("not implemented")
Status: captenpluginspb.StatusCode_OK,
StatusMessage: "ok",
}, nil
}

func (a *Agent) GetCloudProviders(ctx context.Context, request *captenpluginspb.GetCloudProvidersRequest) (
*captenpluginspb.GetCloudProvidersResponse, error) {
a.log.Infof("Get Cloud Provider request recieved")
res, err := a.as.GetCloudProviders()
if err != nil {
a.log.Errorf("failed to get CloudProviders from db, %v", err)
return &captenpluginspb.GetCloudProvidersResponse{
Status: captenpluginspb.StatusCode_INTERNAL_ERROR,
StatusMessage: "failed to fetch cloud providers",
}, nil
}

for _, r := range res {
cloudAttributes, err := a.getCloudProviderCredential(ctx, r.Id)
if err != nil {
a.log.Errorf("failed to get credential, %v", err)
return &captenpluginspb.GetCloudProvidersResponse{
Status: captenpluginspb.StatusCode_INTERNAL_ERROR,
StatusMessage: "failed to fetch cloud providers",
}, nil
}
r.CloudAttributes = cloudAttributes
}

a.log.Infof("Found %d cloud providers", len(res))
return &captenpluginspb.GetCloudProvidersResponse{
Status: captenpluginspb.StatusCode_NOT_FOUND,
StatusMessage: "not implemented",
}, fmt.Errorf("not implemented")
Status: captenpluginspb.StatusCode_OK,
StatusMessage: "successful",
CloudProviders: res,
}, nil

}

func (a *Agent) GetCloudProvidersWithFilter(ctx context.Context, request *captenpluginspb.GetCloudProvidersWithFilterRequest) (
*captenpluginspb.GetCloudProvidersWithFilterResponse, error) {
if len(request.GetLabels()) == 0 {
a.log.Infof("request validation failed")
return &captenpluginspb.GetCloudProvidersWithFilterResponse{
Status: captenpluginspb.StatusCode_INVALID_ARGUMENT,
StatusMessage: "request validation failed",
}, nil
}
a.log.Infof("Get Cloud providers with labels %v request recieved", request.Labels)

res, err := a.as.GetCloudProvidersByLabelsAndCloudType(request.Labels, request.CloudType)
if err != nil {
a.log.Errorf("failed to get CloudProviders for labels from db, %v", err)
return &captenpluginspb.GetCloudProvidersWithFilterResponse{
Status: captenpluginspb.StatusCode_INTERNAL_ERROR,
StatusMessage: "failed to fetch cloud providers",
}, nil
}

for _, r := range res {
cloudAttributes, err := a.getCloudProviderCredential(ctx, r.Id)
if err != nil {
a.log.Errorf("failed to get credential, %v", err)
return &captenpluginspb.GetCloudProvidersWithFilterResponse{
Status: captenpluginspb.StatusCode_INTERNAL_ERROR,
StatusMessage: "failed to fetch cloud providers",
}, nil
}
r.CloudAttributes = cloudAttributes
}

a.log.Infof("Found %d cloud providers for lables %v and cloud type %v", len(res), request.Labels, request.CloudType)
return &captenpluginspb.GetCloudProvidersWithFilterResponse{
Status: captenpluginspb.StatusCode_OK,
StatusMessage: "successful",
CloudProviders: res,
}, nil
}

func (a *Agent) getCloudProviderCredential(ctx context.Context, id string) (map[string]string, error) {
credPath := fmt.Sprintf("%s/%s/%s", credentials.GenericCredentialType, cloudProviderEntityName, id)
credAdmin, err := credentials.NewCredentialAdmin(ctx)
if err != nil {
a.log.Audit("security", "storecred", "failed", "system", "failed to intialize credentials client for %s", credPath)
a.log.Errorf("failed to get crendential for %s, %v", credPath, err)
return nil, err
}

cred, err := credAdmin.GetCredential(ctx, credentials.GenericCredentialType, cloudProviderEntityName, id)
if err != nil {
a.log.Errorf("failed to get credential for %s, %v", credPath, err)
return nil, err
}
return cred, nil
}

func (a *Agent) GetCloudProvidersForLabels(ctx context.Context, request *captenpluginspb.GetCloudProvidersForLabelsRequest) (
*captenpluginspb.GetCloudProvidersForLabelsResponse, error) {
return &captenpluginspb.GetCloudProvidersForLabelsResponse{
Status: captenpluginspb.StatusCode_NOT_FOUND,
StatusMessage: "not implemented",
}, fmt.Errorf("not implemented")
func (a *Agent) storeCloudProviderCredential(ctx context.Context, id string, credentialMap map[string]string) error {
credPath := fmt.Sprintf("%s/%s/%s", credentials.GenericCredentialType, cloudProviderEntityName, id)
credAdmin, err := credentials.NewCredentialAdmin(ctx)
if err != nil {
a.log.Audit("security", "storecred", "failed", "system", "failed to intialize credentials client for %s", credPath)
a.log.Errorf("failed to store credential for %s, %v", credPath, err)
return err
}

err = credAdmin.PutCredential(ctx, credentials.GenericCredentialType, cloudProviderEntityName,
id, credentialMap)

if err != nil {
a.log.Audit("security", "storecred", "failed", "system", "failed to store crendential for %s", credPath)
a.log.Errorf("failed to store credential for %s, %v", credPath, err)
return err
}
a.log.Audit("security", "storecred", "success", "system", "credential stored for %s", credPath)
a.log.Infof("stored credential for entity %s", credPath)
return nil
}
Loading
Loading