experiment with a Store<K> parameter for Reflectors - #102
clippy
1 error, 6 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 1 |
| Warning | 6 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.83.0-nightly (04a318787 2024-09-15)
- cargo 1.83.0-nightly (c1fa840a8 2024-08-29)
- clippy 0.1.82 (04a3187 2024-09-15)
Annotations
Check failure on line 53 in kube/src/runtime/reflector.rs
github-actions / clippy
mismatched types
error[E0308]: mismatched types
--> kube/src/runtime/reflector.rs:48:9
|
41 | impl<K, S> GenericReflector<K, S>
| - expected this type parameter
...
47 | pub fn new(api: Api<K>) -> Self {
| ---- expected `runtime::reflector::GenericReflector<K, S>` because of return type
48 | / Reflector {
49 | | api,
50 | | params: ListParams::default(),
51 | | version: Arc::new(Mutex::new(0.to_string())),
52 | | store: Default::default(),
53 | | }
| |_________^ expected `GenericReflector<K, S>`, found `GenericReflector<K, ...>`
|
= note: expected struct `runtime::reflector::GenericReflector<_, S>`
found struct `runtime::reflector::GenericReflector<_, std::collections::BTreeMap<runtime::reflector::ObjectId, K>>`
Check warning on line 109 in kube/src/config/file_loader.rs
github-actions / clippy
use of deprecated method `openssl::pkcs12::Pkcs12Builder::build`: Use Self::{name, pkey, cert, build2} instead.
warning: use of deprecated method `openssl::pkcs12::Pkcs12Builder::build`: Use Self::{name, pkey, cert, build2} instead.
--> kube/src/config/file_loader.rs:109:37
|
109 | let p12 = Pkcs12::builder().build(password, "kubeconfig", &pkey, &x509)?;
| ^^^^^
|
= note: `#[warn(deprecated)]` on by default
Check warning on line 83 in kube/src/runtime/reflector.rs
github-actions / clippy
unused variable: `sigterm`
warning: unused variable: `sigterm`
--> kube/src/runtime/reflector.rs:83:17
|
83 | sigterm = sigterm_fut => {
| ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sigterm`
Check warning on line 79 in kube/src/runtime/reflector.rs
github-actions / clippy
unused variable: `ctrlc`
warning: unused variable: `ctrlc`
--> kube/src/runtime/reflector.rs:79:17
|
79 | ctrlc = ctrlc_fut => {
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_ctrlc`
|
= note: `#[warn(unused_variables)]` on by default
Check warning on line 155 in kube/src/client/mod.rs
github-actions / clippy
bound is defined in more than one place
warning: bound is defined in more than one place
--> kube/src/client/mod.rs:155:33
|
155 | pub async fn request_events<T: Clone + Meta>(
| ^
...
160 | T: DeserializeOwned,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
= note: `#[warn(clippy::multiple_bound_locations)]` on by default
Check warning on line 171 in kube/src/api/object.rs
github-actions / clippy
elided lifetime has a name
warning: elided lifetime has a name
--> kube/src/api/object.rs:171:63
|
171 | pub fn iter_mut<'a>(&'a mut self) -> impl Iterator<Item = &mut T> + 'a {
| -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a`
Check warning on line 148 in kube/src/api/object.rs
github-actions / clippy
elided lifetime has a name
warning: elided lifetime has a name
--> kube/src/api/object.rs:148:55
|
148 | pub fn iter<'a>(&'a self) -> impl Iterator<Item = &T> + 'a {
| -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a`
|
= note: `#[warn(elided_named_lifetimes)]` on by default