-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove scheduler::Error
#827
Conversation
Updates the requirements on [tokio-util](https://github.com/tokio-rs/tokio) to permit the latest version. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](https://github.com/tokio-rs/tokio/commits) --- updated-dependencies: - dependency-name: tokio-util dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Teo Klestrup Röijezon <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #827 +/- ##
==========================================
+ Coverage 69.92% 70.00% +0.08%
==========================================
Files 58 58
Lines 3983 3977 -6
==========================================
- Hits 2785 2784 -1
+ Misses 1198 1193 -5
Continue to review full report at Codecov.
|
This depends on kube-rs#826 Signed-off-by: Teo Klestrup Röijezon <[email protected]>
f2175a3
to
45d87b0
Compare
@clux Is it fine to ignore the cargo-deny failures for now, or do we want to wait for the upstreams to release their own upgrades? |
LGTM. duplicate dep from h2 via hyper tho. |
Signed-off-by: Teo Klestrup Röijezon <[email protected]>
b005b1a
to
a493d01
Compare
hm, to me, this one is probably OK to merge - i don't think we expose anything from tokio_util that will be needed by other users to pass to their tokio_util. it would be nice to know when we can remove ignore directives though somehow :( |
Cargo deny will start yelling once there are no more dependencies that match the skip clause. The downside is that this would probably only pop up in some completely unrelated PR... |
I think it's also set to be a warning - so we would have to just catch it in the output atm. |
let's put a pin in this until after a 0.69 release so we can merge all the ones that require cargo-deny overrides after that. |
@clux Are we ready to merge this now that 0.69 is out? |
ah, yes, let's carry on :-) |
#826 neuters
scheduler::Error
into a void type (sinceDelayQueue
is now infallible). This followup PR removes it completely, as well as any usages of it.