-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for EC private keys #804
Conversation
306a076
to
09b3256
Compare
Note that this PR alone won't be enough to make k3s work as the default kubeconfig uses IP addresses. The relevant feature request is here: briansmith/webpki#54. |
b9dfee0
to
56fa5cf
Compare
This comment was marked as spam.
This comment was marked as spam.
Realised that the jobs here never ran, hence the sudden activity. The red deny ❌ looks like what was fixed in master. |
Signed-off-by: Vladimir Pouzanov <[email protected]>
Signed-off-by: Vladimir Pouzanov <[email protected]>
Signed-off-by: Vladimir Pouzanov <[email protected]>
56fa5cf
to
5f2cc49
Compare
The deps caught up, this is now ready for review. |
CI test failure remaining on cargo-deny: hyper-rustls brings in an older version of |
Can confirm that this works on Earlier error:
New bypassable error:
Bypass: #153 (add @farcaller : it nothing major, all the real tests pass, and the pr works perfectly 👍 . the failing check is |
We will add an override file for this after making a 0.69 release (today/tomorrow), and merge this right after. then hopefully the ecosystem acquires internal consistency in the mean time (or else 0.70 release will be released with the override). in either case don't want to delay this too much, but want to try to keep the set of dependencies consistent |
Override added so all checks passing now. Merging. Thanks again! |
Motivation
Allows to use kube-rs with e.g. k3s and k3d default installs that use the Sec1 private keys.
Solution
This depends on