-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
self-driving reflector + signal handling #218
Conversation
Seems like re-using Informer is the source of the new resourceVersion issues. Not sure why this is, Informers function perfectly well on their own? EDIT: NOT TRUE. Reproduced the same problem with a configmap_informer in an old namespace. Every poll after the first causes a 410 Gone desync. Ok, seems the list + watch from the list point is more resilient than the event stream.. From k8s docs:
So, will revert the Informer dependency I guess. |
Will revert the resourceVersion parsing, even by doing that, it's not solving the problem. Informer and Reflector has to list on old namespaces #219. |
906cc0e
to
4d42621
Compare
fixes #151 and fixes #152 with tokio::signal and a futures::select call. drops a lot of Reflector logic to defer to Informer. Seems to work pretty well, but may need to deal with desyncs better. Ran into the unordered resourceVersion issue on a really old namespace. Need to double check if that can happen with old version.
was an attempt to get around #219 but didn't work
also for #219
this will work in kubernetes >= 1.16 - see #219 for now, don't break the it.
make secret reflector a little nicer to look at
fixes #151 and fixes #152 with tokio::signal and a futures::select call.
drops a lot of Reflector logic to defer to Informer.Also changes the api of Informer and Reflector to have clean constructors:
Seems to work pretty well, but may need to deal with desyncs better.Ran into the unordered resourceVersion issue on a really old namespace.
Need to double check if that can happen with old version.
The examples that are converted herein seem to work fine. Signal handler also works.