-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilise runtime predicates #1578
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are unlikely to undergo much changes (and if they do they are completely separated). This should be an easy feature cleanup in runtime, and one less need for unstable-runtime for common setups (i use this all the time). Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1578 +/- ##
=====================================
Coverage 75.2% 75.2%
=====================================
Files 82 82
Lines 7334 7334
=====================================
Hits 5514 5514
Misses 1820 1820
|
Signed-off-by: clux <[email protected]>
Signed-off-by: Eirik A <[email protected]>
mateiidavid
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻 seems like a sensible thing to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are unlikely to undergo much changes (and they are basically a completely separate part in the codebase). This should be an easy feature cleanup in runtime, and one less need for unstable-runtime for common setups (i use this all the time).
This removes the
kube_runtime/unstable-runtime-predicates
feature and thus removes the need for users to usekube/unstable-runtime
if they only are usingpredicates
.Public api wise; this exposes the
Predicate
trait, theWatchStreamExt::predicate_filter
fn, and by necessity the (unconstructible)PredicateFilter
stream wrapper type.(Not planning on merging until near the release cycle in case any more fixes come in).
Idea via kube-rs/controller-rs#50 (comment)