Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilise runtime predicates #1578

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Stabilise runtime predicates #1578

merged 5 commits into from
Oct 9, 2024

Conversation

clux
Copy link
Member

@clux clux commented Sep 13, 2024

These are unlikely to undergo much changes (and they are basically a completely separate part in the codebase). This should be an easy feature cleanup in runtime, and one less need for unstable-runtime for common setups (i use this all the time).

This removes the kube_runtime/unstable-runtime-predicates feature and thus removes the need for users to use kube/unstable-runtime if they only are using predicates.

Public api wise; this exposes the Predicate trait, the WatchStreamExt::predicate_filter fn, and by necessity the (unconstructible) PredicateFilter stream wrapper type.

(Not planning on merging until near the release cycle in case any more fixes come in).
Idea via kube-rs/controller-rs#50 (comment)

These are unlikely to undergo much changes (and if they do they are completely separated).
This should be an easy feature cleanup in runtime,
and one less need for unstable-runtime for common setups (i use this all the time).

Signed-off-by: clux <[email protected]>
@clux clux added the changelog-add changelog added category for prs label Sep 13, 2024
@clux clux added this to the 0.95.0 milestone Sep 13, 2024
Signed-off-by: clux <[email protected]>
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.2%. Comparing base (6688421) to head (9cdf619).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1578   +/-   ##
=====================================
  Coverage   75.2%   75.2%           
=====================================
  Files         82      82           
  Lines       7334    7334           
=====================================
  Hits        5514    5514           
  Misses      1820    1820           
Files with missing lines Coverage Δ
kube-runtime/src/utils/mod.rs 62.3% <ø> (ø)
kube-runtime/src/utils/watch_ext.rs 22.3% <ø> (ø)

@clux clux marked this pull request as ready for review September 13, 2024 19:23
@clux clux added the runtime controller runtime related label Sep 14, 2024
@clux clux modified the milestones: 0.95.0, 0.96.0 Sep 16, 2024
@clux clux requested a review from mateiidavid October 8, 2024 12:45
Copy link
Contributor

@mateiidavid mateiidavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 seems like a sensible thing to do.

@clux clux merged commit 62f95cd into main Oct 9, 2024
18 checks passed
@clux clux deleted the predicate-stabilise branch October 9, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-add changelog added category for prs runtime controller runtime related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants