Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to provide headers to send as client #1523

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

aviramha
Copy link
Contributor

Closes #1521

Signed-off-by: Aviram Hassan <[email protected]>
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.1%. Comparing base (41549bc) to head (d2f37da).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1523     +/-   ##
=======================================
- Coverage   75.1%   75.1%   -0.0%     
=======================================
  Files         78      78             
  Lines       6978    6980      +2     
=======================================
  Hits        5238    5238             
- Misses      1740    1742      +2     
Files Coverage Δ
kube-client/src/client/config_ext.rs 53.0% <100.0%> (-0.6%) ⬇️
kube-client/src/config/mod.rs 45.0% <33.4%> (-0.4%) ⬇️

Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks easy enough. One Q on clarity.

kube-client/src/config/mod.rs Show resolved Hide resolved
@clux clux added the changelog-add changelog added category for prs label Jun 18, 2024
@clux clux added this to the 0.93.0 milestone Jun 18, 2024
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@clux clux merged commit f553c4e into kube-rs:main Jun 19, 2024
17 checks passed
@aviramha aviramha deleted the headers_fun branch August 7, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-add changelog added category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to add headers to the client
2 participants