Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance buffer-metrics sidecar #1826

Merged
merged 2 commits into from
Oct 11, 2024
Merged

feat: enhance buffer-metrics sidecar #1826

merged 2 commits into from
Oct 11, 2024

Conversation

csatib02
Copy link
Member

This PR enchances the buffer-metrics sidecar container by:

  • Adding a new config option for setting a liveness probe.
  • Increasing default resource values.

@csatib02 csatib02 added the enhancement New feature or request label Oct 11, 2024
@csatib02 csatib02 self-assigned this Oct 11, 2024
@csatib02 csatib02 force-pushed the feat/update-buffer-metrics-sidecar branch from 1b77638 to 8980364 Compare October 11, 2024 12:17
@csatib02 csatib02 requested review from pepov and OverOrion October 11, 2024 12:20
@csatib02 csatib02 linked an issue Oct 11, 2024 that may be closed by this pull request
buffer-metrics-sidecar should have healthy-check #1811
Closed
pepov
pepov approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@pepov pepov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, looks good overall!

pkg/sdk/logging/api/v1beta1/fluentd_types.go Outdated Show resolved Hide resolved
@csatib02 csatib02 force-pushed the feat/update-buffer-metrics-sidecar branch from 287959e to 4bd0c76 Compare October 11, 2024 16:38
@csatib02 csatib02 force-pushed the feat/update-buffer-metrics-sidecar branch from 4bd0c76 to efcba86 Compare October 11, 2024 16:39
@pepov pepov merged commit 9d341f5 into master Oct 11, 2024
19 checks passed
@pepov pepov deleted the feat/update-buffer-metrics-sidecar branch October 11, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepov pepov pepov approved these changes

@OverOrion OverOrion Awaiting requested review from OverOrion

Assignees

@csatib02 csatib02

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

buffer-metrics-sidecar should have healthy-check
2 participants
@csatib02 @pepov