Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging operator issues 118 #128

Closed
wants to merge 6 commits into from
Closed

Logging operator issues 118 #128

wants to merge 6 commits into from

Conversation

imriss
Copy link

@imriss imriss commented Aug 16, 2019

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #118
License Apache 2.0

What's in this PR?

Added lua filter for dedot of Kubernetes labels (based on this comment).

Why?

was getting this 400 error in the logs:

ERROR: Can't merge a non object mapping [kubernetes.labels.app] with an object mapping [kubernetes.labels.app]

Additional context

Checklist

  • Implementation tested (with at least one cloud provider)
  • Error handling code meets the guideline
  • Logging code meets the guideline (TODO)
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

To Do

  • If the PR is not complete but you want to discuss the approach, list what remains to be done here

@CLAassistant
Copy link

CLAassistant commented Aug 16, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@imriss
Copy link
Author

imriss commented Aug 17, 2019

PR 129 covers this. This one can be closed.

@imriss imriss closed this Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@imriss @CLAassistant