Fix web-burner cluster-density workload #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Castillo Lema <[email protected]>
vishnuchalla
reviewed
May 2, 2024
| @@ -0,0 +1,49 @@ | |||
| --- | |||
There was a problem hiding this comment.
Can this filename go with cluster_density* prefix to keep the naming consistent across the directory, please?
|
@josecastillolema Looks like files in this PR got missed previously while adding web-burner cluster density workload. I think adding a CI test will prevent us from running into similar problems in future. So I would kindly request you to add a test in this PR itself, if it is not too much of work. Thanks. |
Signed-off-by: Jose Castillo Lema <[email protected]>
|
@vishnuchalla all comments addressed ptal |
|
@vishnuchalla kindly reminder, can we have this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Closes #60
TODO: Add test cases for the web-burner-cluster-density scenario, today the CI only covers web-burner-node-density