Remove default metrics and alerts in BYOWL workloads #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsevilla87
added
enhancement
Signed-off-by: Raul Sevilla <[email protected]>
rsevilla87
force-pushed
the
remove-byowl-metrics
branch
from
b985d29 to
d98d295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
These workloads shouldn't require an alerts.yml and metrics.yml files in the same directory where they run, their metricsProfiles can be configured. At the moment it's only possible to configure metrics/alerts by using the metrics-endpoint flag, but once kube-burner/kube-burner#611 gets merged, we should be able to configure them through the configuration file too
Related Tickets & Documents
Checklist before requesting a review