Disable default cluster health check in BYOWL workloads #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raul Sevilla <[email protected]>
rsevilla87
force-pushed
the
cluster-health-check
branch
from
dc0298c to
d571a67
Compare
vishnuchalla
reviewed
Apr 5, 2024
| @@ -38,15 +36,6 @@ func NewClusterDensity(wh *workloads.WorkloadHelper, variant string) *cobra.Comm | |||
| Use: variant, | |||
| Short: fmt.Sprintf("Runs %v workload", variant), | |||
| PreRun: func(cmd *cobra.Command, args []string) { | |||
| kubeClientProvider := config.NewKubeClientProvider("", "") | |||
There was a problem hiding this comment.
Don't we want cluster health check in cluster-density?
There was a problem hiding this comment.
It can be enabled in all workloads https://github.com/kube-burner/kube-burner-ocp/blob/main/cmd/ocp.go#L85-L87
I removed it from cluster-density to standarize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Cluster health check shouldn't be executed in custom-workload and cluster-density by default. A user should opt-out this functionally with the flags.
Related Tickets & Documents
Checklist before requesting a review