Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing git config for docs #41

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Changing git config for docs #41

merged 1 commit into from
Apr 1, 2024

Conversation

vishnuchalla
Copy link
Contributor

@vishnuchalla vishnuchalla commented Mar 30, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Keeping git config username and email different from kube-burner docs workflow.

Related Tickets & Documents

Related Issue: Having same git config on both the repos might tamper the docs deploy workflows. So keep them different from each other.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

This change will be originally tested when cut a release. But in dev environment, tested and verified by deleting older tags and keep the below two doc links updated.

@vishnuchalla vishnuchalla requested review from a team as code owners March 30, 2024 17:16
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rsevilla87 rsevilla87 merged commit eb497be into kube-burner:main Apr 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants