Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert replace-import as it not required #38

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Revert replace-import as it not required #38

merged 1 commit into from
Mar 29, 2024

Conversation

vishnuchalla
Copy link
Contributor

@vishnuchalla vishnuchalla commented Mar 29, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Reverting this change as someone can simply clone the latest KB and replace it using the below command in their local

go mod edit  -replace  github.com/kube-burner/kube-burner=/home/rsevilla/labs/kube-burner

This is very specific to having knowledge in GO and contributors using KB as dependency are expected to have knowledge about fixing dependency issues.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

@vishnuchalla vishnuchalla requested review from a team as code owners March 29, 2024 20:53
Copy link
Contributor

@shashank-boyapally shashank-boyapally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vishnuchalla vishnuchalla merged commit e53cdd8 into kube-burner:main Mar 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants