Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding make target to replace imports #35

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Adding make target to replace imports #35

merged 1 commit into from
Mar 26, 2024

Conversation

vishnuchalla
Copy link
Contributor

@vishnuchalla vishnuchalla commented Mar 26, 2024 •
edited
Loading

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Adding a make target to replace imports as follow up for this PR: https://github.com/kube-burner/kube-burner/pull/613/files

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

@vishnuchalla vishnuchalla requested review from a team as code owners March 26, 2024 02:45
@vishnuchalla vishnuchalla requested a review from krishvoor March 26, 2024 02:46
krishvoor
krishvoor approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@krishvoor krishvoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking neat - /lgtm

@krishvoor krishvoor merged commit d3ec059 into kube-burner:main Mar 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishvoor krishvoor krishvoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishnuchalla @krishvoor